summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQi Wang <qiwan@redhat.com>2020-10-30 10:48:07 -0400
committerQi Wang <qiwan@redhat.com>2020-10-30 11:00:40 -0400
commitcab33cfbf6a729778afd6740e81df4f647514214 (patch)
tree96812011f71e1c049e7892b0177d85b73c4e67b5
parent228396a99dc88fc828f23d4072a46ca8de90282f (diff)
downloadpodman-cab33cfbf6a729778afd6740e81df4f647514214.tar.gz
podman-cab33cfbf6a729778afd6740e81df4f647514214.tar.bz2
podman-cab33cfbf6a729778afd6740e81df4f647514214.zip
Remove search limit since pagination support
Remove the search limit check since the c/image v5.6.0 supports pagination and can give result over 100 entries. Signed-off-by: Qi Wang <qiwan@redhat.com>
-rw-r--r--cmd/podman/images/search.go4
-rw-r--r--docs/source/markdown/podman-search.1.md2
-rw-r--r--test/e2e/search_test.go7
3 files changed, 8 insertions, 5 deletions
diff --git a/cmd/podman/images/search.go b/cmd/podman/images/search.go
index b1a1442a6..3d8be5c71 100644
--- a/cmd/podman/images/search.go
+++ b/cmd/podman/images/search.go
@@ -98,10 +98,6 @@ func imageSearch(cmd *cobra.Command, args []string) error {
return errors.Errorf("search requires exactly one argument")
}
- if searchOptions.Limit > 100 {
- return errors.Errorf("Limit %d is outside the range of [1, 100]", searchOptions.Limit)
- }
-
if searchOptions.ListTags && len(searchOptions.Filters) != 0 {
return errors.Errorf("filters are not applicable to list tags result")
}
diff --git a/docs/source/markdown/podman-search.1.md b/docs/source/markdown/podman-search.1.md
index fc09d96ea..15a38383a 100644
--- a/docs/source/markdown/podman-search.1.md
+++ b/docs/source/markdown/podman-search.1.md
@@ -62,7 +62,7 @@ Note: use .Tag only if the --list-tags is set.
**--limit**=*limit*
-Limit the number of results. This value can be in the range between 1 and 100. The default number of results is 25.
+Limit the number of results (default 25).
Note: The results from each registry will be limited to this value.
Example if limit is 10 and two registries are being searched, the total
number of results will be 20, 10 from each (if there are at least 10 matches in each).
diff --git a/test/e2e/search_test.go b/test/e2e/search_test.go
index 4f2751099..424a191c5 100644
--- a/test/e2e/search_test.go
+++ b/test/e2e/search_test.go
@@ -460,4 +460,11 @@ registries = ['{{.Host}}:{{.Port}}']`
search.WaitWithDefaultTimeout()
Expect(len(search.OutputToStringArray()) == 0).To(BeTrue())
})
+
+ It("podman search with limit over 100", func() {
+ search := podmanTest.Podman([]string{"search", "--limit", "130", "registry.redhat.io/rhel"})
+ search.WaitWithDefaultTimeout()
+ Expect(search.ExitCode()).To(Equal(0))
+ Expect(len(search.OutputToStringArray())).To(Equal(131))
+ })
})