diff options
| author | Šimon Lukašík <slukasik@redhat.com> | 2018-11-10 10:44:03 +0100 |
|---|---|---|
| committer | Šimon Lukašík <slukasik@redhat.com> | 2018-11-10 10:52:24 +0100 |
| commit | e93834576036ef0a5e1d5867e522d1d90a63d358 (patch) | |
| tree | d6fec513a777ce6440701ee73cc15a9c9f4dce52 | |
| parent | 7457815ba930fdabff6ee57f4b7ec29d9fbcfcf8 (diff) | |
| download | podman-e93834576036ef0a5e1d5867e522d1d90a63d358.tar.gz podman-e93834576036ef0a5e1d5867e522d1d90a63d358.tar.bz2 podman-e93834576036ef0a5e1d5867e522d1d90a63d358.zip | |
Lint: Silence few given goconst lint warnings
While we have these string literals on repeated on multiple places in the
library, I cannot see real tangible benefit extracting these to constants
considering following facts:
(1) while 'unknown' or 'host' are repeated, they are often times used in
different context and thus perhaps worth extra const per each use.
(2) while these string literals repeat, the library is full of string literals
with special meaning that should be made constants too
(3) readability would suffer
Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| -rwxr-xr-x | .tool/lint | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/.tool/lint b/.tool/lint index 60ba3f32a..f7bf81c1d 100755 --- a/.tool/lint +++ b/.tool/lint @@ -41,6 +41,7 @@ ${LINTER} \ --exclude='duplicate of.*_test.go.*\(dupl\)$'\ --exclude='cmd\/client\/.*\.go.*\(dupl\)$'\ --exclude='libpod\/.*_easyjson.go:.*'\ + --exclude='.* other occurrence\(s\) of "(container|host|tmpfs|unknown)" found in: .*\(goconst\)$'\ --exclude='vendor\/.*'\ --exclude='podman\/.*'\ --exclude='server\/seccomp\/.*\.go.*$'\ |