Merge pull request #1717 from jwhonce/wip/unittest

Ensure test container in running state

2 files changed, 8 insertions, 4 deletions

diff --git a/contrib/python/podman/test/test_images.py b/contrib/python/podman/test/test_images.py
index f6b95f98a..f97e13b4c 100644
--- a/contrib/python/podman/test/test_images.py
+++ b/contrib/python/podman/test/test_images.py
@@ -6,6 +6,7 @@ from datetime import datetime, timezone
 from test.podman_testcase import PodmanTestCase
 
 import podman
+from podman import FoldedString
 
 
 class TestImages(PodmanTestCase):
@@ -44,6 +45,7 @@ class TestImages(PodmanTestCase):
         self.assertGreaterEqual(len(actual), 2)
         self.assertIsNotNone(self.alpine_image)
 
+    @unittest.skip('TODO: missing buildah json file')
     def test_build(self):
         path = os.path.join(self.tmpdir, 'ctnr', 'Dockerfile')
         img, logs = self.pclient.images.build(
@@ -59,12 +61,12 @@ class TestImages(PodmanTestCase):
     def test_create(self):
         img_details = self.alpine_image.inspect()
 
-        actual = self.alpine_image.container()
+        actual = self.alpine_image.container(command=['sleep',  '1h'])
         self.assertIsNotNone(actual)
-        self.assertEqual(actual.status, 'configured')
+        self.assertEqual(FoldedString(actual.status), 'configured')
 
         ctnr = actual.start()
-        self.assertIn(ctnr.status, ['running', 'stopped', 'exited'])
+        self.assertEqual(FoldedString(ctnr.status), 'running')
 
         ctnr_details = ctnr.inspect()
         for e in img_details.containerconfig['env']:
diff --git a/contrib/python/podman/test/test_runner.sh b/contrib/python/podman/test/test_runner.sh
index 65cbd1e9c..bf097e2b2 100755
--- a/contrib/python/podman/test/test_runner.sh
+++ b/contrib/python/podman/test/test_runner.sh
@@ -31,7 +31,9 @@ function cleanup {
   # aggressive cleanup as tests may crash leaving crap around
   umount '^(shm|nsfs)'
   umount '\/run\/netns'
-  rm -r "$1"
+  if [[ $RETURNCODE -eq 0 ]]; then
+    rm -r "$1"
+  fi
 }
 
 # Create temporary directory for storage