fix bug dest path of copying tar

when podman cp tar without --extract flag, if the destination already exists, or ends with path seprator, cp the tar under the directory, otherwise copy the tar named with the destination

Signed-off-by: Qi Wang <qiwan@redhat.com>

2 files changed, 31 insertions, 0 deletions

diff --git a/cmd/podman/cp.go b/cmd/podman/cp.go
index 4cb8a8c54..8240cc193 100644
--- a/cmd/podman/cp.go
+++ b/cmd/podman/cp.go
@@ -272,6 +272,10 @@ func copy(src, destPath, dest string, idMappingOpts storage.IDMappingOptions, ch
 		}
 		return nil
 	}
+
+	if destDirIsExist || strings.HasSuffix(dest, string(os.PathSeparator)) {
+		destPath = filepath.Join(destPath, filepath.Base(srcPath))
+	}
 	// Copy the file, preserving attributes.
 	logrus.Debugf("copying %q to %q", srcPath, destPath)
 	if err = copyFileWithTar(srcPath, destPath); err != nil {
diff --git a/test/e2e/cp_test.go b/test/e2e/cp_test.go
index 1dfa8f50d..16e03472e 100644
--- a/test/e2e/cp_test.go
+++ b/test/e2e/cp_test.go
@@ -143,4 +143,31 @@ var _ = Describe("Podman cp", func() {
 		os.Remove("file.tar.gz")
 		os.RemoveAll(testDirPath)
 	})
+
+	It("podman cp tar", func() {
+		path, err := os.Getwd()
+		Expect(err).To(BeNil())
+		testDirPath := filepath.Join(path, "TestDir")
+		err = os.Mkdir(testDirPath, 0777)
+		Expect(err).To(BeNil())
+		cmd := exec.Command("tar", "-cvf", "file.tar", testDirPath)
+		_, err = cmd.Output()
+		Expect(err).To(BeNil())
+
+		session := podmanTest.Podman([]string{"create", "--name", "testctr", ALPINE, "ls", "-l", "foo"})
+		session.WaitWithDefaultTimeout()
+		Expect(session.ExitCode()).To(Equal(0))
+
+		session = podmanTest.Podman([]string{"cp", "file.tar", "testctr:/foo/"})
+		session.WaitWithDefaultTimeout()
+		Expect(session.ExitCode()).To(Equal(0))
+
+		session = podmanTest.Podman([]string{"start", "-a", "testctr"})
+		session.WaitWithDefaultTimeout()
+		Expect(session.ExitCode()).To(Equal(0))
+		Expect(session.OutputToString()).To(ContainSubstring("file.tar"))
+
+		os.Remove("file.tar")
+		os.RemoveAll(testDirPath)
+	})
 })