Add a binding test to check image tag and list commands.

Include testcase to validate tag api responses and check if
all the image instaces are shown list command.
Also, Update the binding process and the response

Signed-off-by: Sujil02 <sushah@redhat.com>

2 files changed, 36 insertions, 2 deletions

diff --git a/pkg/bindings/errors.go b/pkg/bindings/errors.go
index 8bd40f804..1bcaac3f0 100644
--- a/pkg/bindings/errors.go
+++ b/pkg/bindings/errors.go
@@ -3,7 +3,6 @@ package bindings
 import (
 	"encoding/json"
 	"io/ioutil"
-	"net/http"
 
 	"github.com/containers/libpod/pkg/api/handlers/utils"
 	"github.com/pkg/errors"
@@ -26,7 +25,7 @@ func (a APIResponse) Process(unmarshalInto interface{}) error {
 	if err != nil {
 		return errors.Wrap(err, "unable to process API response")
 	}
-	if a.Response.StatusCode == http.StatusOK {
+	if a.IsSuccess() {
 		if unmarshalInto != nil {
 			return json.Unmarshal(data, unmarshalInto)
 		}
diff --git a/pkg/bindings/test/images_test.go b/pkg/bindings/test/images_test.go
index 227f28d16..f2dc856b2 100644
--- a/pkg/bindings/test/images_test.go
+++ b/pkg/bindings/test/images_test.go
@@ -89,4 +89,39 @@ var _ = Describe("Podman images", func() {
 
 	})
 
+	//Tests to validate the image tag command.
+	It("tag image", func() {
+		// Validates if invalid image name is given a bad response is encountered.
+		err = images.Tag(connText, "dummy", "demo", "alpine")
+		Expect(err).ToNot(BeNil())
+		code, _ := bindings.CheckResponseCode(err)
+		Expect(code).To(BeNumerically("==", 404))
+
+		// Validates if the image is tagged sucessfully.
+		err = images.Tag(connText, "alpine", "demo", "alpine")
+		Expect(err).To(BeNil())
+
+		//Validates if name updates when the image is retagged.
+		_, err := images.GetImage(connText, "alpine:demo", nil)
+		Expect(err).To(BeNil())
+
+	})
+
+	//Test to validate the List images command.
+	It("List image", func() {
+		//Array to hold the list of images returned
+		imageSummary, err := images.List(connText, nil, nil)
+		//There Should be no errors in the response.
+		Expect(err).To(BeNil())
+		//Since in the begin context only one image is created the list context should have only one image
+		Expect(len(imageSummary)).To(Equal(1))
+
+		//To be written create a new image and check list count again
+		//imageSummary, err = images.List(connText, nil, nil)
+
+		//Since in the begin context only one image adding one more image should
+		///Expect(len(imageSummary)).To(Equal(2)
+
+	})
+
 })