summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrent Baude <bbaude@redhat.com>2020-08-04 13:41:44 -0500
committerBrent Baude <bbaude@redhat.com>2020-08-04 15:31:51 -0500
commit7590a415d005abcb7774ced296c219822d47991a (patch)
tree43ac6abb498244e3427ffa514e1f0a4cd997d8c5
parentd4cf3c589d09dd395a3b63e82f5a5c198535cb46 (diff)
downloadpodman-7590a415d005abcb7774ced296c219822d47991a.tar.gz
podman-7590a415d005abcb7774ced296c219822d47991a.tar.bz2
podman-7590a415d005abcb7774ced296c219822d47991a.zip
correct go-binding key for volumes
the go binding for remove container was using 'vols' for a key to remove volumes associated to the container. the correct key should be "v" and is documented as such. Fixes: #7128 Signed-off-by: Brent Baude <bbaude@redhat.com>
-rw-r--r--pkg/bindings/containers/containers.go2
-rw-r--r--test/system/160-volumes.bats2
2 files changed, 1 insertions, 3 deletions
diff --git a/pkg/bindings/containers/containers.go b/pkg/bindings/containers/containers.go
index 9e6dbef19..9913b773b 100644
--- a/pkg/bindings/containers/containers.go
+++ b/pkg/bindings/containers/containers.go
@@ -98,7 +98,7 @@ func Remove(ctx context.Context, nameOrID string, force, volumes *bool) error {
params.Set("force", strconv.FormatBool(*force))
}
if volumes != nil {
- params.Set("vols", strconv.FormatBool(*volumes))
+ params.Set("v", strconv.FormatBool(*volumes))
}
response, err := conn.DoRequest(nil, http.MethodDelete, "/containers/%s", params, nil, nameOrID)
if err != nil {
diff --git a/test/system/160-volumes.bats b/test/system/160-volumes.bats
index ef38b2a68..e2aefed43 100644
--- a/test/system/160-volumes.bats
+++ b/test/system/160-volumes.bats
@@ -142,8 +142,6 @@ EOF
# Anonymous temporary volumes, and persistent autocreated named ones
@test "podman volume, implicit creation with run" {
- skip_if_remote "FIXME: pending #7128"
-
# No hostdir arg: create anonymous container with random name
rand=$(random_string)
run_podman run -v /myvol $IMAGE sh -c "echo $rand >/myvol/myfile"