summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValentin Rothberg <rothberg@redhat.com>2019-07-08 13:55:44 +0200
committerValentin Rothberg <rothberg@redhat.com>2019-07-08 14:25:51 +0200
commit2d1e52d3e9b9304c3d3ce6ede23cd819d6893df5 (patch)
treeee0103e6f22a530634d8f52e5b6810b8d38c7631
parentf7407f2eb512e1407f8281009eb829f37405119b (diff)
downloadpodman-2d1e52d3e9b9304c3d3ce6ede23cd819d6893df5.tar.gz
podman-2d1e52d3e9b9304c3d3ce6ede23cd819d6893df5.tar.bz2
podman-2d1e52d3e9b9304c3d3ce6ede23cd819d6893df5.zip
CONTRIBUTING.md: fix project paths
The paths to the local libpod tree where missing the `./src` part which ultimately lead to compilation errors. Also place the git trees into containers/libpod and not into the user's GitHub root. Reported in #podman on IRC. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
-rw-r--r--CONTRIBUTING.md14
1 files changed, 4 insertions, 10 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b86f3e345..59b0a88da 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -48,18 +48,12 @@ First you need to fork this project on GitHub.
Be sure to have [defined your `$GOPATH` environment variable](https://github.com/golang/go/wiki/GOPATH).
-Create a path that correspond to your clone `mkdir -p $GOPATH/github.com/<you>`.
+Create a path that corresponds to the go import paths of libpod: `mkdir -p $GOPATH/src/github.com/containers`.
-Clone your fork locally:
+Then clone your fork locally:
```shell
-$ git clone git@github.com:<you>/libpod github.com/<you> $GOPATH/github.com/<you>/libpod
-$ cd $GOPATH/github.com/<you>/libpod
-```
-
-You can also use `go get` to clone your fork:
-```shell
-$ go get github.com:<you>/libpod
-$ cd $GOPATH/github.com/<you>/libpod
+$ git clone git@github.com:<you>/libpod $GOPATH/src/github.com/containers/libpod
+$ cd $GOPATH/src/github.com/containers/libpod
```
### Deal with make