summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>2019-03-01 09:13:34 -0800
committerGitHub <noreply@github.com>2019-03-01 09:13:34 -0800
commitc0bc88decc236a7898ba05d9815fb5df7c050f44 (patch)
tree461bb3e418576ebb5749a6dd4ff4d015316e772c
parent0bf06b9e3b2af08c4cb2f4d6f6d598671f326051 (diff)
parent711c0569716b30ef8a027a9412ac5ba6df981230 (diff)
downloadpodman-c0bc88decc236a7898ba05d9815fb5df7c050f44.tar.gz
podman-c0bc88decc236a7898ba05d9815fb5df7c050f44.tar.bz2
podman-c0bc88decc236a7898ba05d9815fb5df7c050f44.zip
Merge pull request #2483 from cevich/important_contrib_note
[ci skip] Add critical note about skip-ci and merge bot
-rw-r--r--CONTRIBUTING.md14
1 files changed, 10 insertions, 4 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b1b166fef..3778d6d7d 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -329,10 +329,16 @@ author hold special privileges on the github repository. Others can be used by
unintentionally. Instead, just write ``LGTM``, or
spell it out.
-* ``[skip ci]``: Within the HEAD commit will cause Cirrus CI to ***NOT*** execute
- tests on the PR. This is useful in basically two cases: 1) You're still working
- and don't want to waste resources. 2) You haven't modified any code that would
- be exercised by the tests. For example, documentation updates (outside of code).
+* ``/hold`` and ``/unhold``: Override the automatic handling of a request. Either
+ put it on hold (no handling) or remove the hold (normal handling).
+
+* ``[ci skip]``: [Adding `[ci skip]` within the HEAD commit](https://cirrus-ci.org/guide/writing-tasks/#conditional-task-execution)
+ will cause Cirrus CI to ***NOT*** execute tests for the PR or after merge. This
+ is useful in only one instance: Your changes are absolutely not exercised by
+ any test. For example, documentation changes. ***IMPORTANT NOTE*** **Other
+ automation may interpret the lack of test results as "PASSED" and unintentionall
+ merge a PR. Consider also using `/hold` in a comment, to add additional
+ protection.**
[The complete list may be found on the command-help page.](https://prow.k8s.io/command-help)
However, not all commands are implemented for this repository. If in doubt, ask a maintainer.