summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2021-08-04 15:21:39 -0600
committerEd Santiago <santiago@redhat.com>2021-08-04 15:24:08 -0600
commitc9e2f2f60b2e3293fe04a06742d411d319d0b93d (patch)
tree1289791fa8bee2dec94515bbd19377fc25296e6d
parent117583c293713f2baa920c4035e820ad59fe6622 (diff)
downloadpodman-c9e2f2f60b2e3293fe04a06742d411d319d0b93d.tar.gz
podman-c9e2f2f60b2e3293fe04a06742d411d319d0b93d.tar.bz2
podman-c9e2f2f60b2e3293fe04a06742d411d319d0b93d.zip
[CI:DOCS] tests-expect-exit: include source line numbers
In the new check for preventing 'Expect(ExitCode...)', include source line numbers. Response to #11034, which I totally didn't even understand because it was referencing a different test. Sorry, Brent. Signed-off-by: Ed Santiago <santiago@redhat.com>
-rw-r--r--Makefile2
1 files changed, 1 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index 32d2f44b7..fbd15bac7 100644
--- a/Makefile
+++ b/Makefile
@@ -607,7 +607,7 @@ tests-included:
.PHONY: tests-expect-exit
tests-expect-exit:
- @if egrep 'Expect.*ExitCode' test/e2e/*.go | egrep -v ', ".*"\)'; then \
+ @if egrep --line-number 'Expect.*ExitCode' test/e2e/*.go | egrep -v ', ".*"\)'; then \
echo "^^^ Unhelpful use of Expect(ExitCode())"; \
echo " Please use '.Should(Exit(...))' pattern instead."; \
echo " If that's not possible, please add an annotation (description) to your assertion:"; \