summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValentin Rothberg <rothberg@redhat.com>2021-01-17 16:37:55 +0100
committerValentin Rothberg <rothberg@redhat.com>2021-01-17 17:24:03 +0100
commit2df59829e4613242b1e6cc3154ffbc22a3f05ea3 (patch)
tree8b897318dd81b106bdca61b396ea882f9f8c7666
parent4629942686de54a8d58036dbce17fbed1c95780c (diff)
downloadpodman-2df59829e4613242b1e6cc3154ffbc22a3f05ea3.tar.gz
podman-2df59829e4613242b1e6cc3154ffbc22a3f05ea3.tar.bz2
podman-2df59829e4613242b1e6cc3154ffbc22a3f05ea3.zip
simplify bindings generation
Run `go generate ./pkg/bindings/...` once for all bindings instead of generating them separately. This should speed up bindings generation as a given package is visited only once, and it fixes #8989 by dropping the use of pushd and popd. Fixes: #8989 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
-rw-r--r--Makefile10
1 files changed, 1 insertions, 9 deletions
diff --git a/Makefile b/Makefile
index 9014b81f7..7d307793c 100644
--- a/Makefile
+++ b/Makefile
@@ -462,15 +462,7 @@ podman-remote-%-release:
BINDINGS_SOURCE = $(wildcard pkg/bindings/**/types.go)
.generate-bindings: $(BINDINGS_SOURCE)
ifneq ($(shell uname -s), Darwin)
- for i in $(BINDINGS_SOURCE); do \
- dirname=$$(dirname $${i}); \
- shortname=$$(basename $${dirname}); \
- pushd $${dirname}>/dev/null; \
- echo $${dirname}; \
- echo $(GO) generate; \
- $(GO) generate -mod=vendor; \
- popd > /dev/null; \
- done;
+ $(GO) generate -mod=vendor ./pkg/bindings/... ;
endif
touch .generate-bindings