summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValentin Rothberg <rothberg@redhat.com>2020-07-21 13:30:07 +0200
committerValentin Rothberg <rothberg@redhat.com>2020-07-21 13:31:43 +0200
commitd628de31d71b1849fdb102f8689faa80fe286b83 (patch)
treee19bb1e811fbf4303895798f582f71dea2e5bdf2
parentdf6920aa79073b2767d24c6524367384b6284b31 (diff)
downloadpodman-d628de31d71b1849fdb102f8689faa80fe286b83.tar.gz
podman-d628de31d71b1849fdb102f8689faa80fe286b83.tar.bz2
podman-d628de31d71b1849fdb102f8689faa80fe286b83.zip
unit tests: root check
The unit tests currently require running as root. This has caused some confusion that justifies adding a root check to `make localunit` and error out for non-root users instead of starting the tests deemed to fail. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
-rw-r--r--Makefile1
-rwxr-xr-xhack/check_root.sh5
2 files changed, 6 insertions, 0 deletions
diff --git a/Makefile b/Makefile
index 71b4772c4..132dde939 100644
--- a/Makefile
+++ b/Makefile
@@ -307,6 +307,7 @@ testunit: libpodimage ## Run unittest on the built image
.PHONY: localunit
localunit: test/goecho/goecho varlink_generate
+ hack/check_root.sh make localunit
ginkgo \
-r \
$(TESTFLAGS) \
diff --git a/hack/check_root.sh b/hack/check_root.sh
new file mode 100755
index 000000000..203eae9d3
--- /dev/null
+++ b/hack/check_root.sh
@@ -0,0 +1,5 @@
+#!/bin/bash
+if ! [ $(id -u) = 0 ]; then
+ echo "Please run as root! '$@' requires root privileges."
+ exit 1
+fi