diff options
author | Paul Holzinger <pholzing@redhat.com> | 2021-11-08 15:22:43 +0100 |
---|---|---|
committer | Paul Holzinger <pholzing@redhat.com> | 2021-11-11 14:27:31 +0100 |
commit | eca1b6c0bdfca59c8c8a85fe29f4159034f311d0 (patch) | |
tree | e78900bcfe5b73a3c776b310a9f8cb8b30a16d9a | |
parent | 8de9950038b5a0582bfecfbe3a11427e6cfbfcfe (diff) | |
download | podman-eca1b6c0bdfca59c8c8a85fe29f4159034f311d0.tar.gz podman-eca1b6c0bdfca59c8c8a85fe29f4159034f311d0.tar.bz2 podman-eca1b6c0bdfca59c8c8a85fe29f4159034f311d0.zip |
pod create: read network mode from config
When we create a pod we have to parse the network mode form the config
file. This is a regression in commit d28e85741f.
Fixes #12207
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
-rw-r--r-- | cmd/podman/pods/create.go | 4 | ||||
-rw-r--r-- | test/e2e/config/containers-netns.conf | 3 | ||||
-rw-r--r-- | test/e2e/pod_create_test.go | 18 |
3 files changed, 23 insertions, 2 deletions
diff --git a/cmd/podman/pods/create.go b/cmd/podman/pods/create.go index b3f84dcd8..58bb799a3 100644 --- a/cmd/podman/pods/create.go +++ b/cmd/podman/pods/create.go @@ -116,7 +116,7 @@ func create(cmd *cobra.Command, args []string) error { return fmt.Errorf("cannot specify no-hosts without an infra container") } flags := cmd.Flags() - createOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, false) + createOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, createOptions.Infra) if err != nil { return err } @@ -139,7 +139,7 @@ func create(cmd *cobra.Command, args []string) error { createOptions.CpusetCpus = infraOptions.CPUSetCPUs createOptions.Pid = infraOptions.PID flags := cmd.Flags() - infraOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, false) + infraOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, createOptions.Infra) if err != nil { return err } diff --git a/test/e2e/config/containers-netns.conf b/test/e2e/config/containers-netns.conf new file mode 100644 index 000000000..3f796f25d --- /dev/null +++ b/test/e2e/config/containers-netns.conf @@ -0,0 +1,3 @@ +[containers] + +netns = "host" diff --git a/test/e2e/pod_create_test.go b/test/e2e/pod_create_test.go index 2ccca28d3..bfdf9fe3b 100644 --- a/test/e2e/pod_create_test.go +++ b/test/e2e/pod_create_test.go @@ -806,4 +806,22 @@ ENTRYPOINT ["sleep","99999"] Expect(ok).To(BeTrue()) }) + It("podman pod create read network mode from config", func() { + confPath, err := filepath.Abs("config/containers-netns.conf") + Expect(err).ToNot(HaveOccurred()) + os.Setenv("CONTAINERS_CONF", confPath) + defer os.Unsetenv("CONTAINERS_CONF") + if IsRemote() { + podmanTest.RestartRemoteService() + } + + pod := podmanTest.Podman([]string{"pod", "create", "--name", "test", "--infra-name", "test-infra"}) + pod.WaitWithDefaultTimeout() + Expect(pod).Should(Exit(0)) + + inspect := podmanTest.Podman([]string{"inspect", "--format", "{{.HostConfig.NetworkMode}}", "test-infra"}) + inspect.WaitWithDefaultTimeout() + Expect(inspect).Should(Exit(0)) + Expect(inspect.OutputToString()).Should(Equal("host")) + }) }) |