aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>2020-12-09 10:15:55 -0500
committerGitHub <noreply@github.com>2020-12-09 10:15:55 -0500
commit3cd143fc5851d5080c5dcdde5e3b227a163f85d9 (patch)
tree713cc9bc8a668cffe1499e9d4de87f114ca0cc49
parent49d11b53e1f19f20253801dbd3a905c831251528 (diff)
parent2d30eff06867d4993a2de7678169f30158a49a74 (diff)
downloadpodman-3cd143fc5851d5080c5dcdde5e3b227a163f85d9.tar.gz
podman-3cd143fc5851d5080c5dcdde5e3b227a163f85d9.tar.bz2
podman-3cd143fc5851d5080c5dcdde5e3b227a163f85d9.zip
Merge pull request #8611 from vrothberg/short-names
enable short-name aliasing
-rw-r--r--libpod/image/pull.go18
1 files changed, 0 insertions, 18 deletions
diff --git a/libpod/image/pull.go b/libpod/image/pull.go
index 2a2d16252..c37929927 100644
--- a/libpod/image/pull.go
+++ b/libpod/image/pull.go
@@ -4,7 +4,6 @@ import (
"context"
"fmt"
"io"
- "os"
"path/filepath"
"strings"
@@ -378,29 +377,12 @@ func (ir *Runtime) doPullImage(ctx context.Context, sc *types.SystemContext, goa
return images, nil
}
-// getShortNameMode looks up the `CONTAINERS_SHORT_NAME_ALIASING` environment
-// variable. If it's "on", return `nil` to use the defaults from
-// containers/image and the registries.conf files on the system. If it's
-// "off", empty or unset, return types.ShortNameModeDisabled to turn off
-// short-name aliasing by default.
-//
-// TODO: remove this function once we want to default to short-name aliasing.
-func getShortNameMode() *types.ShortNameMode {
- env := os.Getenv("CONTAINERS_SHORT_NAME_ALIASING")
- if strings.ToLower(env) == "on" {
- return nil // default to whatever registries.conf and c/image decide
- }
- mode := types.ShortNameModeDisabled
- return &mode
-}
-
// pullGoalFromPossiblyUnqualifiedName looks at inputName and determines the possible
// image references to try pulling in combination with the registries.conf file as well
func (ir *Runtime) pullGoalFromPossiblyUnqualifiedName(sys *types.SystemContext, writer io.Writer, inputName string) (*pullGoal, error) {
if sys == nil {
sys = &types.SystemContext{}
}
- sys.ShortNameMode = getShortNameMode()
resolved, err := shortnames.Resolve(sys, inputName)
if err != nil {