diff options
author | Brent Baude <bbaude@redhat.com> | 2022-03-08 15:44:40 -0600 |
---|---|---|
committer | Jason T. Greene <jason.greene@redhat.com> | 2022-03-18 15:06:57 -0500 |
commit | 35b2d951b2f648632f4b358ddb470acd2a41483f (patch) | |
tree | 60474eb1e7b79e43564e414bd2480a557270b273 | |
parent | 76a910b16934cc801fabc5dfa2c6c25731efbe97 (diff) | |
download | podman-35b2d951b2f648632f4b358ddb470acd2a41483f.tar.gz podman-35b2d951b2f648632f4b358ddb470acd2a41483f.tar.bz2 podman-35b2d951b2f648632f4b358ddb470acd2a41483f.zip |
machine rm -f stops and removes machine
If you want to remove a running machine, you can now pass the --force/-f
to podman machine rm and the machine will be stopped and removed without
confirmations.
Fixes: #13448
[NO NEW TESTS NEEDED]
Signed-off-by: Brent Baude <bbaude@redhat.com>
-rw-r--r-- | cmd/podman/machine/rm.go | 4 | ||||
-rw-r--r-- | docs/source/markdown/podman-machine-rm.1.md | 8 | ||||
-rw-r--r-- | pkg/machine/qemu/machine.go | 2 |
3 files changed, 9 insertions, 5 deletions
diff --git a/cmd/podman/machine/rm.go b/cmd/podman/machine/rm.go index 38873084a..3e5d5fb0b 100644 --- a/cmd/podman/machine/rm.go +++ b/cmd/podman/machine/rm.go @@ -37,7 +37,7 @@ func init() { flags := rmCmd.Flags() formatFlagName := "force" - flags.BoolVar(&destoryOptions.Force, formatFlagName, false, "Do not prompt before rming") + flags.BoolVarP(&destoryOptions.Force, formatFlagName, "f", false, "Stop and do not prompt before rming") keysFlagName := "save-keys" flags.BoolVar(&destoryOptions.SaveKeys, keysFlagName, false, "Do not delete SSH keys") @@ -64,7 +64,7 @@ func rm(cmd *cobra.Command, args []string) error { if err != nil { return err } - confirmationMessage, remove, err := vm.Remove(vmName, machine.RemoveOptions{}) + confirmationMessage, remove, err := vm.Remove(vmName, destoryOptions) if err != nil { return err } diff --git a/docs/source/markdown/podman-machine-rm.1.md b/docs/source/markdown/podman-machine-rm.1.md index 7c9eb65c5..4eea1d2e4 100644 --- a/docs/source/markdown/podman-machine-rm.1.md +++ b/docs/source/markdown/podman-machine-rm.1.md @@ -23,9 +23,9 @@ is used. Print usage statement. -#### **--force** +#### **--force**, **-f** -Delete without confirmation +Stop and delete without confirmation #### **--save-ignition** @@ -58,6 +58,10 @@ The following files will be deleted: Are you sure you want to continue? [y/N] y ``` +``` +$ podman machine rm -f test1 +$ +``` ## SEE ALSO **[podman(1)](podman.1.md)**, **[podman-machine(1)](podman-machine.1.md)** diff --git a/pkg/machine/qemu/machine.go b/pkg/machine/qemu/machine.go index 2f399b60e..e4e2824d2 100644 --- a/pkg/machine/qemu/machine.go +++ b/pkg/machine/qemu/machine.go @@ -679,7 +679,7 @@ func (v *MachineVM) Remove(name string, opts machine.RemoveOptions) (string, fun if err != nil { return "", nil, err } - if running { + if running && !opts.Force { return "", nil, errors.Errorf("running vm %q cannot be destroyed", v.Name) } |