diff options
| author | Lars Karlitski <lars@karlitski.net> | 2019-02-04 18:18:31 +0100 |
|---|---|---|
| committer | Lars Karlitski <lars@karlitski.net> | 2019-02-12 14:47:49 +0100 |
| commit | 608019b65b2fb3dc1c88efcbed1cd88b70794fd7 (patch) | |
| tree | f6baa48fa0549fa02b41464195a77b8d4f17e983 | |
| parent | 10982bcf849021a56aa113cf8442e888a10f5dde (diff) | |
| download | podman-608019b65b2fb3dc1c88efcbed1cd88b70794fd7.tar.gz podman-608019b65b2fb3dc1c88efcbed1cd88b70794fd7.tar.bz2 podman-608019b65b2fb3dc1c88efcbed1cd88b70794fd7.zip | |
varlink: Remove the Ping() method
There are other ways for developers to "ensure their varlink setup is
working", for example by calling `GetVersion()` or any call on the
org.varlink.service interface.
Signed-off-by: Lars Karlitski <lars@karlitski.net>
| -rw-r--r-- | cmd/podman/varlink/io.podman.varlink | 15 | ||||
| -rw-r--r-- | pkg/varlinkapi/system.go | 8 |
2 files changed, 0 insertions, 23 deletions
diff --git a/cmd/podman/varlink/io.podman.varlink b/cmd/podman/varlink/io.podman.varlink index 9a8d2ed0d..deb3b31eb 100644 --- a/cmd/podman/varlink/io.podman.varlink +++ b/cmd/podman/varlink/io.podman.varlink @@ -13,9 +13,6 @@ type Version ( remote_api_version: int ) -type StringResponse ( - message: string -) # ContainerChanges describes the return struct for ListContainerChanges type ContainerChanges ( changed: []string, @@ -402,18 +399,6 @@ type Runlabel( opts: [string]string ) -# Ping provides a response for developers to ensure their varlink setup is working. -# #### Example -# ~~~ -# $ varlink call -m unix:/run/podman/io.podman/io.podman.Ping -# { -# "ping": { -# "message": "OK" -# } -# } -# ~~~ -method Ping() -> (ping: StringResponse) - # GetVersion returns a Version structure describing the libpod setup on their # system. method GetVersion() -> (version: Version) diff --git a/pkg/varlinkapi/system.go b/pkg/varlinkapi/system.go index 376502f21..0c063cee9 100644 --- a/pkg/varlinkapi/system.go +++ b/pkg/varlinkapi/system.go @@ -25,14 +25,6 @@ func (i *LibpodAPI) GetVersion(call iopodman.VarlinkCall) error { }) } -// Ping returns a simple string "OK" response for clients to make sure -// the service is working. -func (i *LibpodAPI) Ping(call iopodman.VarlinkCall) error { - return call.ReplyPing(iopodman.StringResponse{ - Message: "OK", - }) -} - // GetInfo returns details about the podman host and its stores func (i *LibpodAPI) GetInfo(call iopodman.VarlinkCall) error { versionInfo, err := libpod.GetVersion() |