summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorumohnani8 <umohnani@redhat.com>2018-02-19 15:39:56 -0500
committerAtomic Bot <atomic-devel@projectatomic.io>2018-02-20 15:16:28 +0000
commit8f8fd1d900303f2f2fe562357c96d0855ff77a5c (patch)
tree72fed4d372361b4ed2155178e1ba530d0f0a4ea4
parent8eb5cf74892611f26c0c42c45312cb84e04882a2 (diff)
downloadpodman-8f8fd1d900303f2f2fe562357c96d0855ff77a5c.tar.gz
podman-8f8fd1d900303f2f2fe562357c96d0855ff77a5c.tar.bz2
podman-8f8fd1d900303f2f2fe562357c96d0855ff77a5c.zip
Fix podman save when redirecting output
podman save would write the progress bar to the image tar file when the output was redirected with >. Fixed the writer to write to stderr for all commands using writer Signed-off-by: umohnani8 <umohnani@redhat.com> Closes: #362 Approved by: mheon
-rw-r--r--cmd/podman/create.go2
-rw-r--r--cmd/podman/load.go2
-rw-r--r--cmd/podman/pull.go3
-rw-r--r--cmd/podman/push.go2
-rw-r--r--cmd/podman/save.go2
5 files changed, 6 insertions, 5 deletions
diff --git a/cmd/podman/create.go b/cmd/podman/create.go
index 5e2ea3969..3d811b58b 100644
--- a/cmd/podman/create.go
+++ b/cmd/podman/create.go
@@ -392,7 +392,7 @@ func imageData(c *cli.Context, runtime *libpod.Runtime, image string) (string, s
// Pull the image
var writer io.Writer
if !c.Bool("quiet") {
- writer = os.Stdout
+ writer = os.Stderr
}
createImage.Pull(writer)
}
diff --git a/cmd/podman/load.go b/cmd/podman/load.go
index ee8a79756..d3a15a2ae 100644
--- a/cmd/podman/load.go
+++ b/cmd/podman/load.go
@@ -93,7 +93,7 @@ func loadCmd(c *cli.Context) error {
var writer io.Writer
if !c.Bool("quiet") {
- writer = os.Stdout
+ writer = os.Stderr
}
options := libpod.CopyOptions{
diff --git a/cmd/podman/pull.go b/cmd/podman/pull.go
index 886f82dd5..5dc9ef2d4 100644
--- a/cmd/podman/pull.go
+++ b/cmd/podman/pull.go
@@ -5,6 +5,7 @@ import (
"os"
"fmt"
+
"github.com/containers/image/types"
"github.com/pkg/errors"
"github.com/projectatomic/libpod/libpod"
@@ -90,7 +91,7 @@ func pullCmd(c *cli.Context) error {
var writer io.Writer
if !c.Bool("quiet") {
- writer = os.Stdout
+ writer = os.Stderr
}
options := libpod.CopyOptions{
diff --git a/cmd/podman/push.go b/cmd/podman/push.go
index 2f0d73ffa..e16b91611 100644
--- a/cmd/podman/push.go
+++ b/cmd/podman/push.go
@@ -118,7 +118,7 @@ func pushCmd(c *cli.Context) error {
var writer io.Writer
if !c.Bool("quiet") {
- writer = os.Stdout
+ writer = os.Stderr
}
var manifestType string
diff --git a/cmd/podman/save.go b/cmd/podman/save.go
index 9ba1cc829..5ceb456f4 100644
--- a/cmd/podman/save.go
+++ b/cmd/podman/save.go
@@ -75,7 +75,7 @@ func saveCmd(c *cli.Context) error {
var writer io.Writer
if !c.Bool("quiet") {
- writer = os.Stdout
+ writer = os.Stderr
}
output := c.String("output")