summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGiuseppe Scrivano <gscrivan@redhat.com>2018-11-20 10:00:20 +0100
committerGiuseppe Scrivano <gscrivan@redhat.com>2018-11-20 17:08:57 +0100
commitfd014029300328c27ddb535d4868858ec47530f8 (patch)
treedca3747a93d13a8fb3e37c054ec89c201403c47e
parentea928f2de6c111aeb92a7584675f2128abd3254e (diff)
downloadpodman-fd014029300328c27ddb535d4868858ec47530f8.tar.gz
podman-fd014029300328c27ddb535d4868858ec47530f8.tar.bz2
podman-fd014029300328c27ddb535d4868858ec47530f8.zip
exec: always make explicit the tty value
otherwise runc will take by default the value used for creating the container. Setting it explicit overrides its default value and we won't end up trying to use a terminal when not available. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1625876 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
-rw-r--r--libpod/oci.go2
1 files changed, 2 insertions, 0 deletions
diff --git a/libpod/oci.go b/libpod/oci.go
index 71da830b5..190a4dc7f 100644
--- a/libpod/oci.go
+++ b/libpod/oci.go
@@ -741,6 +741,8 @@ func (r *OCIRuntime) execContainer(c *Container, cmd, capAdd, env []string, tty
if tty {
args = append(args, "--tty")
+ } else {
+ args = append(args, "--tty=false")
}
if user != "" {