diff options
| author | Valentin Rothberg <vrothberg@redhat.com> | 2022-06-03 11:38:21 +0200 |
|---|---|---|
| committer | Valentin Rothberg <vrothberg@redhat.com> | 2022-06-03 14:22:25 +0200 |
| commit | 2b0cb30026c6568af11c32d351b7c9dd7e9821af (patch) | |
| tree | b469a7a32d3093e4ca0f79e5b97a11f0863b9ab2 | |
| parent | f7a54088c30dd71a625527aecd740bac8086ccdb (diff) | |
| download | podman-2b0cb30026c6568af11c32d351b7c9dd7e9821af.tar.gz podman-2b0cb30026c6568af11c32d351b7c9dd7e9821af.tar.bz2 podman-2b0cb30026c6568af11c32d351b7c9dd7e9821af.zip | |
test/e2e/save_test.go: fix flake
Save at most three images and sort them by size. The test started to
flake as _all_ local images were saved which is not neccessary.
Fixes: #14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| -rw-r--r-- | test/e2e/save_test.go | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/test/e2e/save_test.go b/test/e2e/save_test.go index 897e49ef7..7a1fb0fc2 100644 --- a/test/e2e/save_test.go +++ b/test/e2e/save_test.go @@ -226,13 +226,17 @@ default-docker: }) It("podman save --multi-image-archive (untagged images)", func() { - // Refer to images via ID instead of tag. - session := podmanTest.Podman([]string{"images", "--format", "{{.ID}}"}) + // #14468: to make execution time more predictable, save at + // most three images and sort them by size. + session := podmanTest.Podman([]string{"images", "--sort", "size", "--format", "{{.ID}}"}) session.WaitWithDefaultTimeout() Expect(session).Should(Exit(0)) ids := session.OutputToStringArray() Expect(len(ids)).To(BeNumerically(">", 1), "We need to have *some* images to save") + if len(ids) > 3 { + ids = ids[:3] + } multiImageSave(podmanTest, ids) }) }) |