diff options
| author | Valentin Rothberg <vrothberg@redhat.com> | 2022-05-24 11:51:25 +0200 |
|---|---|---|
| committer | Valentin Rothberg <vrothberg@redhat.com> | 2022-05-24 16:07:39 +0200 |
| commit | 6c6e97018768ab5e0eeccc34ee4de64887fde119 (patch) | |
| tree | 48b02cb5a934dfa4afeea6a929937c028317f86f | |
| parent | d924c46dae55a8846f33ca3346f5c816df9fbf0d (diff) | |
| download | podman-6c6e97018768ab5e0eeccc34ee4de64887fde119.tar.gz podman-6c6e97018768ab5e0eeccc34ee4de64887fde119.tar.bz2 podman-6c6e97018768ab5e0eeccc34ee4de64887fde119.zip | |
pkg/bindings/images: remove TODOs re: system context
A global system context does not make sense for the _bindings_, so
remove the TODOs.
[NO TESTS NEEDED]
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| -rw-r--r-- | pkg/bindings/images/images.go | 2 | ||||
| -rw-r--r-- | pkg/bindings/images/pull.go | 1 |
2 files changed, 0 insertions, 3 deletions
diff --git a/pkg/bindings/images/images.go b/pkg/bindings/images/images.go index 8e3b07929..32372019b 100644 --- a/pkg/bindings/images/images.go +++ b/pkg/bindings/images/images.go @@ -280,7 +280,6 @@ func Push(ctx context.Context, source string, destination string, options *PushO if err != nil { return err } - // TODO: have a global system context we can pass around (1st argument) header, err := auth.MakeXRegistryAuthHeader(&imageTypes.SystemContext{AuthFilePath: options.GetAuthfile()}, options.GetUsername(), options.GetPassword()) if err != nil { return err @@ -329,7 +328,6 @@ func Search(ctx context.Context, term string, options *SearchOptions) ([]entitie params.Set("tlsVerify", strconv.FormatBool(!options.GetSkipTLSVerify())) } - // TODO: have a global system context we can pass around (1st argument) header, err := auth.MakeXRegistryAuthHeader(&imageTypes.SystemContext{AuthFilePath: options.GetAuthfile()}, "", "") if err != nil { return nil, err diff --git a/pkg/bindings/images/pull.go b/pkg/bindings/images/pull.go index 20e47179c..de02c62fd 100644 --- a/pkg/bindings/images/pull.go +++ b/pkg/bindings/images/pull.go @@ -42,7 +42,6 @@ func Pull(ctx context.Context, rawImage string, options *PullOptions) ([]string, params.Set("tlsVerify", strconv.FormatBool(!options.GetSkipTLSVerify())) } - // TODO: have a global system context we can pass around (1st argument) header, err := auth.MakeXRegistryAuthHeader(&types.SystemContext{AuthFilePath: options.GetAuthfile()}, options.GetUsername(), options.GetPassword()) if err != nil { return nil, err |