diff options
| author | Ed Santiago <santiago@redhat.com> | 2022-07-05 15:59:32 -0600 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2022-07-05 15:59:32 -0600 |
| commit | 791dbf8232ebea6bb98a62873e2e66310bc2f73d (patch) | |
| tree | 7c183baab0e44a92e739a300bf2d2dd2fb5c814e | |
| parent | cf747399b13432d000cfd9556a248681363dda2d (diff) | |
| download | podman-791dbf8232ebea6bb98a62873e2e66310bc2f73d.tar.gz podman-791dbf8232ebea6bb98a62873e2e66310bc2f73d.tar.bz2 podman-791dbf8232ebea6bb98a62873e2e66310bc2f73d.zip | |
golangci install: explicitly set BINDIR
The golangci installer (which is curl pipe sh, ewww) installs
into $BINDIR, which it gets from the caller's environment.
Make sure we set it explicitly.
Signed-off-by: Ed Santiago <santiago@redhat.com>
| -rwxr-xr-x | hack/install_golangci.sh | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/hack/install_golangci.sh b/hack/install_golangci.sh index 4ef6bc83b..896d59901 100755 --- a/hack/install_golangci.sh +++ b/hack/install_golangci.sh @@ -9,14 +9,17 @@ function install() { curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v$VERSION } -BIN="./bin/golangci-lint" +# Undocumented behavior: golangci-lint installer requires $BINDIR in env, +# will default to ./bin but we can't rely on that. +export BINDIR="./bin" +BIN="$BINDIR/golangci-lint" if [ ! -x "$BIN" ]; then install else # Prints its own file name as part of --version output $BIN --version | grep "$VERSION" if [ $? -eq 0 ]; then - echo "Using existing $(dirname $BIN)/$($BIN --version)" + echo "Using existing $BINDIR/$($BIN --version)" else install fi |