summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorW. Trevor King <wking@tremily.us>2018-04-27 13:20:45 -0700
committerAtomic Bot <atomic-devel@projectatomic.io>2018-04-28 07:45:30 +0000
commiteda0fd74680dc8d3f1dd0432d7268b73503f2581 (patch)
tree3c5ac7d8557797d9ea0fd5c3563f05faf761dacb
parent13290d65bae094385bb84f3caff3eeae8fddc571 (diff)
downloadpodman-eda0fd74680dc8d3f1dd0432d7268b73503f2581.tar.gz
podman-eda0fd74680dc8d3f1dd0432d7268b73503f2581.tar.bz2
podman-eda0fd74680dc8d3f1dd0432d7268b73503f2581.zip
CONTRIBUTING: Document PR approval and link to OWNERS
Remove a dead "Becoming a Maintainer" link and that stub section, since libpod currently doesn't document that process. By leaving it undocumented, maintainer changes falls back to the usual pull-request review process. Signed-off-by: W. Trevor King <wking@tremily.us> Closes: #688 Approved by: rhatdan
-rw-r--r--CONTRIBUTING.md21
1 files changed, 2 insertions, 19 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index ce39aeda8..684a2ab6e 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -8,7 +8,6 @@ that we follow.
* [Reporting Issues](#reporting-issues)
* [Submitting Pull Requests](#submitting-pull-requests)
* [Communications](#communications)
-* [Becoming a Maintainer](#becoming-a-maintainer)
## Reporting Issues
@@ -55,9 +54,7 @@ PRs that fix issues should include a reference like `Closes #XXXX` in the
commit message so that github will automatically close the referenced issue
when the PR is merged.
-<!--
-All PRs require at least two LGTMs (Looks Good To Me) from maintainers.
--->
+PRs will be approved by an [approver][owners] listed in [`OWNERS`](OWNERS).
### Sign your PRs
@@ -124,18 +121,4 @@ and
[PRs](https://github.com/projectatomic/libpod/pulls)
tracking system.
-<!--
-## Becoming a Maintainer
-
-To become a maintainer you must first be nominated by an existing maintainer.
-If a majority (>50%) of maintainers agree then the proposal is adopted and
-you will be added to the list.
-
-Removing a maintainer requires at least 75% of the remaining maintainers
-approval, or if the person requests to be removed then it is automatic.
-Normally, a maintainer will only be removed if they are considered to be
-inactive for a long period of time or are viewed as disruptive to the community.
-
-The current list of maintainers can be found in the
-[MAINTAINERS](MAINTAINERS) file.
--->
+[owners]: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#owners