summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnders F Björklund <anders.f.bjorklund@gmail.com>2021-03-22 22:09:16 +0100
committerAnders F Björklund <anders.f.bjorklund@gmail.com>2021-03-26 07:14:47 +0100
commit826c228035297585df2e7716ebc4398e6acb63b7 (patch)
tree3010ae62175a0dc4a10c0fd5d6c2d395dd00667f
parent9e23e0b3e3b219cbdc42fac4f843d6d2ec97421b (diff)
downloadpodman-826c228035297585df2e7716ebc4398e6acb63b7.tar.gz
podman-826c228035297585df2e7716ebc4398e6acb63b7.tar.bz2
podman-826c228035297585df2e7716ebc4398e6acb63b7.zip
Fix swapped dimensions from terminal.GetSize
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
-rw-r--r--pkg/bindings/containers/attach.go2
-rw-r--r--test/system/450-interactive.bats2
2 files changed, 1 insertions, 3 deletions
diff --git a/pkg/bindings/containers/attach.go b/pkg/bindings/containers/attach.go
index f48b99a95..ecae22a1b 100644
--- a/pkg/bindings/containers/attach.go
+++ b/pkg/bindings/containers/attach.go
@@ -336,7 +336,7 @@ func attachHandleResize(ctx, winCtx context.Context, winChange chan os.Signal, i
case <-winCtx.Done():
return
case <-winChange:
- h, w, err := terminal.GetSize(int(file.Fd()))
+ w, h, err := terminal.GetSize(int(file.Fd()))
if err != nil {
logrus.Warnf("failed to obtain TTY size: %v", err)
}
diff --git a/test/system/450-interactive.bats b/test/system/450-interactive.bats
index 33841bc16..d047b9f25 100644
--- a/test/system/450-interactive.bats
+++ b/test/system/450-interactive.bats
@@ -49,8 +49,6 @@ function teardown() {
# BEGIN tests
@test "podman detects correct tty size" {
- skip_if_remote "FIXME: resolved in #9782"
-
# Set the pty to a random size. Make rows/columns odd/even, to guarantee
# that they can never be the same
rows=$(( 15 + RANDOM % 60 | 1 ))