summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDivyansh Kamboj <kambojdivyansh2000@gmail.com>2019-05-20 21:15:47 +0530
committerDivyansh Kamboj <kambojdivyansh2000@gmail.com>2019-05-20 23:11:48 +0530
commitc6f7066e772b2ee761665cbff027c3b1906fd171 (patch)
tree2c47d68239de69aa06d0e3c25a5303ef30f05547
parent18a953918e1d15aded713f9802865807bd25a1e0 (diff)
downloadpodman-c6f7066e772b2ee761665cbff027c3b1906fd171.tar.gz
podman-c6f7066e772b2ee761665cbff027c3b1906fd171.tar.bz2
podman-c6f7066e772b2ee761665cbff027c3b1906fd171.zip
Minor fix filtering images by label
Added test to avoid future regressions Fix #3163 Signed-off-by: Divyansh Kamboj <kambojdivyansh2000@gmail.com>
-rw-r--r--cmd/podman/images.go2
-rw-r--r--test/e2e/images_test.go13
2 files changed, 14 insertions, 1 deletions
diff --git a/cmd/podman/images.go b/cmd/podman/images.go
index 1c46571c3..3f755efc1 100644
--- a/cmd/podman/images.go
+++ b/cmd/podman/images.go
@@ -362,7 +362,7 @@ func CreateFilterFuncs(ctx context.Context, r *adapter.LocalRuntime, filters []s
var filterFuncs []imagefilters.ResultFilter
for _, filter := range filters {
splitFilter := strings.Split(filter, "=")
- if len(splitFilter) != 2 {
+ if len(splitFilter) < 2 {
return nil, errors.Errorf("invalid filter syntax %s", filter)
}
switch splitFilter[0] {
diff --git a/test/e2e/images_test.go b/test/e2e/images_test.go
index bec6e304b..23455163b 100644
--- a/test/e2e/images_test.go
+++ b/test/e2e/images_test.go
@@ -298,4 +298,17 @@ ENV foo=bar
Expect(session2.ExitCode()).To(Equal(0))
Expect(len(session2.OutputToStringArray())).To(Equal(6))
})
+
+ It("podman images filter by label", func() {
+ SkipIfRemote()
+ dockerfile := `FROM docker.io/library/alpine:latest
+LABEL version="1.0"
+LABEL "com.example.vendor"="Example Vendor"
+`
+ podmanTest.BuildImage(dockerfile, "test", "true")
+ session := podmanTest.Podman([]string{"images", "-f", "label=version=1.0"})
+ session.WaitWithDefaultTimeout()
+ Expect(session.ExitCode()).To(Equal(0))
+ Expect(len(session.OutputToStringArray())).To(Equal(2))
+ })
})