diff options
author | Matthew Heon <matthew.heon@pm.me> | 2019-03-29 12:51:37 -0400 |
---|---|---|
committer | Matthew Heon <matthew.heon@pm.me> | 2019-03-29 12:51:37 -0400 |
commit | 81088012475cef5fbc136af1767d9d5a7327ee66 (patch) | |
tree | e1442651b7b4c20a321256b179272c8ef0e7c388 | |
parent | f4d90a96cb7eabde3d999390619aae683e05b00e (diff) | |
download | podman-81088012475cef5fbc136af1767d9d5a7327ee66.tar.gz podman-81088012475cef5fbc136af1767d9d5a7327ee66.tar.bz2 podman-81088012475cef5fbc136af1767d9d5a7327ee66.zip |
Add locking to ensure events file is concurrency-safe
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
-rw-r--r-- | libpod/events/events.go | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/libpod/events/events.go b/libpod/events/events.go index 7db36653e..fad129eff 100644 --- a/libpod/events/events.go +++ b/libpod/events/events.go @@ -6,6 +6,7 @@ import ( "os" "time" + "github.com/containers/storage" "github.com/pkg/errors" ) @@ -122,6 +123,13 @@ func NewEvent(status Status) Event { // Write will record the event to the given path func (e *Event) Write(path string) error { + // We need to lock events file + lock, err := storage.GetLockfile(path + ".lock") + if err != nil { + return err + } + lock.Lock() + defer lock.Unlock() f, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0700) if err != nil { return err |