diff options
author | Paul Holzinger <pholzing@redhat.com> | 2021-11-08 15:22:43 +0100 |
---|---|---|
committer | Paul Holzinger <pholzing@redhat.com> | 2021-11-08 18:59:28 +0100 |
commit | 8b7b0b7caf104fbd0c04869296f395b51c5e211e (patch) | |
tree | 73abed1fa641eab972f230737a888f2e48ee73b6 | |
parent | d6ef903164512e6fa7903bb0b85a1852117df37b (diff) | |
download | podman-8b7b0b7caf104fbd0c04869296f395b51c5e211e.tar.gz podman-8b7b0b7caf104fbd0c04869296f395b51c5e211e.tar.bz2 podman-8b7b0b7caf104fbd0c04869296f395b51c5e211e.zip |
pod create: read network mode from config
When we create a pod we have to parse the network mode form the config
file. This is a regression in commit d28e85741f.
Fixes #12207
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
-rw-r--r-- | cmd/podman/pods/create.go | 4 | ||||
-rw-r--r-- | test/e2e/config/containers-netns.conf | 3 | ||||
-rw-r--r-- | test/e2e/pod_create_test.go | 18 |
3 files changed, 23 insertions, 2 deletions
diff --git a/cmd/podman/pods/create.go b/cmd/podman/pods/create.go index 0a0d43b53..b966706b4 100644 --- a/cmd/podman/pods/create.go +++ b/cmd/podman/pods/create.go @@ -117,7 +117,7 @@ func create(cmd *cobra.Command, args []string) error { return fmt.Errorf("cannot specify no-hosts without an infra container") } flags := cmd.Flags() - createOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, false) + createOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, createOptions.Infra) if err != nil { return err } @@ -134,7 +134,7 @@ func create(cmd *cobra.Command, args []string) error { } else { // reassign certain options for lbpod api, these need to be populated in spec flags := cmd.Flags() - infraOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, false) + infraOptions.Net, err = common.NetFlagsToNetOptions(nil, *flags, createOptions.Infra) if err != nil { return err } diff --git a/test/e2e/config/containers-netns.conf b/test/e2e/config/containers-netns.conf new file mode 100644 index 000000000..3f796f25d --- /dev/null +++ b/test/e2e/config/containers-netns.conf @@ -0,0 +1,3 @@ +[containers] + +netns = "host" diff --git a/test/e2e/pod_create_test.go b/test/e2e/pod_create_test.go index 34e879ed4..12aeffd1b 100644 --- a/test/e2e/pod_create_test.go +++ b/test/e2e/pod_create_test.go @@ -957,4 +957,22 @@ ENTRYPOINT ["sleep","99999"] Expect(ctr3.OutputToString()).To(ContainSubstring("hello")) }) + It("podman pod create read network mode from config", func() { + confPath, err := filepath.Abs("config/containers-netns.conf") + Expect(err).ToNot(HaveOccurred()) + os.Setenv("CONTAINERS_CONF", confPath) + defer os.Unsetenv("CONTAINERS_CONF") + if IsRemote() { + podmanTest.RestartRemoteService() + } + + pod := podmanTest.Podman([]string{"pod", "create", "--name", "test", "--infra-name", "test-infra"}) + pod.WaitWithDefaultTimeout() + Expect(pod).Should(Exit(0)) + + inspect := podmanTest.Podman([]string{"inspect", "--format", "{{.HostConfig.NetworkMode}}", "test-infra"}) + inspect.WaitWithDefaultTimeout() + Expect(inspect).Should(Exit(0)) + Expect(inspect.OutputToString()).Should(Equal("host")) + }) }) |