diff options
author | W. Trevor King <wking@tremily.us> | 2018-05-21 10:24:26 -0700 |
---|---|---|
committer | W. Trevor King <wking@tremily.us> | 2018-09-13 22:10:58 -0700 |
commit | da42c60307addba1a4cef609c339891028ca450d (patch) | |
tree | 75becf8400ac847bdb4a9f84a3ffb7f240185068 | |
parent | e2137cd009376af0f66855221bd2605bd3297104 (diff) | |
download | podman-da42c60307addba1a4cef609c339891028ca450d.tar.gz podman-da42c60307addba1a4cef609c339891028ca450d.tar.bz2 podman-da42c60307addba1a4cef609c339891028ca450d.zip |
Makefile: Call contrib/python's clean regardless of HAS_PYTHON3
The only Python dependency in contrib/python's clean is:
$(PYTHON) setup.py clean --all
and our setup.pys work on both major Python versions:
$ make -C contrib/python/podman PYTHON=python2 clean
make: Entering directory `/.../libpod/contrib/python/podman'
python2 setup.py clean --all
/usr/lib64/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'python_requires'
warnings.warn(msg)
running clean
'build/lib' does not exist -- can't clean it
'build/bdist.linux-x86_64' does not exist -- can't clean it
'build/scripts-2.7' does not exist -- can't clean it
rm -rf podman.egg-info dist
find . -depth -name __pycache__ -exec rm -rf {} \;
find . -depth -name \*.pyc -exec rm -f {} \;
make: Leaving directory `/.../libpod/contrib/python/podman'
$ echo $?
0
$ make -C contrib/python/pypodman PYTHON=python2 clean
make: Entering directory `/.../libpod/contrib/python/pypodman'
python2 setup.py clean --all
/usr/lib64/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'python_requires'
warnings.warn(msg)
running clean
removing 'build/lib' (and everything under it)
removing 'build/bdist.linux-x86_64' (and everything under it)
'build/scripts-2.7' does not exist -- can't clean it
removing 'build'
rm -rf pypodman.egg-info dist
find . -depth -name __pycache__ -exec rm -rf {} \;
find . -depth -name \*.pyc -exec rm -f {} \;
make: Leaving directory `/.../libpod/contrib/python/pypodman'
$ echo $?
0
This rolls back part of 390bd16d (tidy up the copr spec, 2018-05-20, #813).
I've also shifted the submake cleans to the end of the main clean
recipe. That way, if one of the submake cleans dies (e.g. because the
system lacks Python entirely), the temp-file removal will still
happen. The way I have it setup now, the podman clean dying will keep
any of the pypodman clean from happening. You could probably work
around that with something like:
$(MAKE) -C contrib/python/podman clean & \
$(MAKE) -C contrib/python/pypodman clean & \
wait
but that seems too fancy for such a corner case.
Signed-off-by: W. Trevor King <wking@tremily.us>
-rw-r--r-- | Makefile | 6 |
1 files changed, 2 insertions, 4 deletions
@@ -138,12 +138,10 @@ clean: libpod/container_easyjson.go \ libpod/pod_easyjson.go \ $(MANPAGES) ||: -ifdef HAS_PYTHON3 - $(MAKE) -C contrib/python/podman clean - $(MAKE) -C contrib/python/pypodman clean -endif find . -name \*~ -delete find . -name \#\* -delete + $(MAKE) -C contrib/python/podman clean + $(MAKE) -C contrib/python/pypodman clean libpodimage: docker build -t ${LIBPOD_IMAGE} . |