summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>2018-12-20 03:43:30 -0800
committerGitHub <noreply@github.com>2018-12-20 03:43:30 -0800
commitc275b2d785441c25bc466f3f2b3bd664f0b0e0f0 (patch)
treed741e591906b102d2f33db5400e383b5ff6ba174
parent6b059a58828b978f30ed416da066987226e88e73 (diff)
parent7a0005bd2d6542df9420c72a185314a8025e1ff0 (diff)
downloadpodman-c275b2d785441c25bc466f3f2b3bd664f0b0e0f0.tar.gz
podman-c275b2d785441c25bc466f3f2b3bd664f0b0e0f0.tar.bz2
podman-c275b2d785441c25bc466f3f2b3bd664f0b0e0f0.zip
Merge pull request #2029 from cevich/gate_docs
[skip ci] Gate: Update docs w/ safer local command
-rw-r--r--CONTRIBUTING.md4
1 files changed, 3 insertions, 1 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 8e921dcf3..32ed94ad4 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -192,6 +192,8 @@ from the repository root, with the command:
sudo podman build -t quay.io/libpod/gate:latest -f contrib/gate/Dockerfile .
```
+***N/B:*** **don't miss the dot (.) at the end, it's really important**
+
The container executes 'make' by default, on a copy of the repository.
This avoids changing or leaving build artifacts in your working directory.
Execution does not require any special permissions from the host. However,
@@ -199,7 +201,7 @@ the repository root must be bind-mounted into the container at
'/usr/src/libpod'. For example, running `make lint` is done (from
the repository root) with the command:
-``sudo podman run -it --rm -v $PWD:/usr/src/libpod:z quay.io/libpod/gate:latest lint``
+``sudo podman run -it --rm -v $PWD:/usr/src/libpod:ro --security-opt label=disable quay.io/libpod/gate:latest lint``
### Integration Tests