summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJake Correnti <jcorrenti13@gmail.com>2022-07-13 21:41:16 -0400
committerJake Correnti <jcorrenti13@gmail.com>2022-07-14 10:54:24 -0400
commit90607a6d04ad96d1821e8f50157d6e8aa600cdf5 (patch)
treea3d667ec843547b0beff9afdb230328102a3167f
parent5c3eec55895c9ca4c36571e1e919f0cb8632bedb (diff)
downloadpodman-90607a6d04ad96d1821e8f50157d6e8aa600cdf5.tar.gz
podman-90607a6d04ad96d1821e8f50157d6e8aa600cdf5.tar.bz2
podman-90607a6d04ad96d1821e8f50157d6e8aa600cdf5.zip
Podman pull --all-tags shorthand option
I added the shorthand option for `podman pull --all-tags`. Like Docker, Podman can now do `podman pull -a`. Signed-off-by: Jake Correnti <jcorrenti13@gmail.com>
-rw-r--r--cmd/podman/images/pull.go2
-rw-r--r--docs/source/markdown/podman-pull.1.md2
-rw-r--r--test/e2e/pull_test.go9
3 files changed, 11 insertions, 2 deletions
diff --git a/cmd/podman/images/pull.go b/cmd/podman/images/pull.go
index 6e3ec1517..8211ceba5 100644
--- a/cmd/podman/images/pull.go
+++ b/cmd/podman/images/pull.go
@@ -77,7 +77,7 @@ func init() {
func pullFlags(cmd *cobra.Command) {
flags := cmd.Flags()
- flags.BoolVar(&pullOptions.AllTags, "all-tags", false, "All tagged images in the repository will be pulled")
+ flags.BoolVarP(&pullOptions.AllTags, "all-tags", "a", false, "All tagged images in the repository will be pulled")
credsFlagName := "creds"
flags.StringVar(&pullOptions.CredentialsCLI, credsFlagName, "", "`Credentials` (USERNAME:PASSWORD) to use for authenticating to a registry")
diff --git a/docs/source/markdown/podman-pull.1.md b/docs/source/markdown/podman-pull.1.md
index 928bbc6fe..99e227226 100644
--- a/docs/source/markdown/podman-pull.1.md
+++ b/docs/source/markdown/podman-pull.1.md
@@ -43,7 +43,7 @@ $ podman pull oci-archive:/tmp/myimage
```
## OPTIONS
-#### **--all-tags**
+#### **--all-tags**, **-a**
All tagged images in the repository will be pulled.
diff --git a/test/e2e/pull_test.go b/test/e2e/pull_test.go
index 04b7a280d..12f14fdc8 100644
--- a/test/e2e/pull_test.go
+++ b/test/e2e/pull_test.go
@@ -108,6 +108,15 @@ var _ = Describe("Podman pull", func() {
session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0))
Expect(len(session.OutputToStringArray())).To(BeNumerically(">=", 2), "Expected at least two images")
+
+ session = podmanTest.Podman([]string{"pull", "-a", "quay.io/libpod/testdigest_v2s2"})
+ session.WaitWithDefaultTimeout()
+ Expect(session).Should(Exit(0))
+
+ session = podmanTest.Podman([]string{"images"})
+ session.WaitWithDefaultTimeout()
+ Expect(session).Should(Exit(0))
+ Expect(len(session.OutputToStringArray())).To(BeNumerically(">=", 2), "Expected at least two images")
})
It("podman pull from docker with nonexistent --authfile", func() {