summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJhon Honce <jhonce@redhat.com>2021-10-14 10:03:26 -0700
committerJhon Honce <jhonce@redhat.com>2021-10-14 13:31:41 -0700
commitab4c9a8948b24a5390b7143131f5ed2ad634a2fb (patch)
treed084a4a0fa21193e17c30c3b2fd2686cadb0eaf6
parentac733032c19a711317edc889bd2cb6321ee3bbdf (diff)
downloadpodman-ab4c9a8948b24a5390b7143131f5ed2ad634a2fb.tar.gz
podman-ab4c9a8948b24a5390b7143131f5ed2ad634a2fb.tar.bz2
podman-ab4c9a8948b24a5390b7143131f5ed2ad634a2fb.zip
Use CGO_ENABLED=1 when building natively on darwin
Need to use CGO for mDNS resolution, but cross builds need CGO disabled See https://github.com/golang/go/issues/12524 for details Note: Homebrew forumla will need to be updated to pick up this change Fixes #10737 Signed-off-by: Jhon Honce <jhonce@redhat.com>
-rw-r--r--Makefile11
1 files changed, 10 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index 7c8c6f1c5..3b70c4f4f 100644
--- a/Makefile
+++ b/Makefile
@@ -176,6 +176,15 @@ define go-get
$(GO) get -u ${1}
endef
+# Need to use CGO for mDNS resolution, but cross builds need CGO disabled
+# See https://github.com/golang/go/issues/12524 for details
+DARWIN_GCO := 0
+ifeq ($(NATIVE_GOOS),darwin)
+ifdef HOMEBREW_PREFIX
+ DARWIN_GCO := 1
+endif
+endif
+
###
### Primary entry-point targets
###
@@ -351,7 +360,7 @@ podman-remote-windows: ## Build podman-remote for Windows
.PHONY: podman-remote-darwin
podman-remote-darwin: ## Build podman-remote for macOS
$(MAKE) \
- CGO_ENABLED=0 \
+ CGO_ENABLED=$(DARWIN_GCO) \
GOOS=darwin \
GOARCH=$(GOARCH) \
bin/darwin/podman