summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>2020-02-20 15:55:31 +0100
committerGitHub <noreply@github.com>2020-02-20 15:55:31 +0100
commite7d8bda8706b98dfc182cf03e294dc1ce83af6d2 (patch)
tree5cf9f49b2234fd987c3dd6d61121089231fa098b
parent126f75d7be3353c2df7ed1c3f9c6e0a7b707422e (diff)
parentdb60abe3d8cf115e42c86ddcaf2dfcbf492801b8 (diff)
downloadpodman-e7d8bda8706b98dfc182cf03e294dc1ce83af6d2.tar.gz
podman-e7d8bda8706b98dfc182cf03e294dc1ce83af6d2.tar.bz2
podman-e7d8bda8706b98dfc182cf03e294dc1ce83af6d2.zip
Merge pull request #5268 from Akasurde/warn_bare_password
Warn user about --password cli option in login
-rw-r--r--cmd/podman/login.go4
1 files changed, 4 insertions, 0 deletions
diff --git a/cmd/podman/login.go b/cmd/podman/login.go
index e5ff273b8..e09117833 100644
--- a/cmd/podman/login.go
+++ b/cmd/podman/login.go
@@ -82,6 +82,10 @@ func loginCmd(c *cliconfig.LoginValues) error {
server = registryFromFullName(scrubServer(args[0]))
}
+ if c.Flag("password").Changed {
+ fmt.Fprintf(os.Stderr, "WARNING! Using --password via the cli is insecure. Please consider using --password-stdin\n")
+ }
+
sc := image.GetSystemContext("", c.Authfile, false)
if c.Flag("tls-verify").Changed {
sc.DockerInsecureSkipTLSVerify = types.NewOptionalBool(!c.TlsVerify)