summaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
diff options
context:
space:
mode:
authorW. Trevor King <wking@tremily.us>2018-05-15 16:10:51 -0700
committerAtomic Bot <atomic-devel@projectatomic.io>2018-05-16 15:42:34 +0000
commit5b2627dd7738cd92a356ca30c5a47be7a6abaf29 (patch)
tree24ad3a1855a755c9c947516239755ccdb0aa6b19 /CONTRIBUTING.md
parent9fcc475d033d7f1718e9490e8944de7f31a2bbab (diff)
downloadpodman-5b2627dd7738cd92a356ca30c5a47be7a6abaf29.tar.gz
podman-5b2627dd7738cd92a356ca30c5a47be7a6abaf29.tar.bz2
podman-5b2627dd7738cd92a356ca30c5a47be7a6abaf29.zip
Makefile: Drop find-godeps.sh for podman target
We inherited this from a031b83a (Initial checkin from CRI-O repo, 2017-11-01), but: * The output is actually going into bin/podman, so Make will rebuild this target every time. You'll never be able to save compilation because the target is newer than all the prerequisites. * Make expands prerequisites immediately when loading a Makefile [1], and on my wimpy Chromebook SD Card, this is *slow*: $ time hack/find-godeps.sh ~/.local/lib/go/src/github.com/projectatomic/libpod cmd/podman github.com/projectatomic/libpod ... real 0m56.225s user 0m44.918s sys 0m21.918s * Go is pretty good at this on its own, so having make call 'go build' every time will almost certainly be faster than us trying to mimic this in a shell script. And by punting to Go in the recipe, Make invocations that do not need the podman target (e.g. 'make help') can skip the dependency lookup entirely. [1]: https://www.gnu.org/software/make/manual/html_node/Reading-Makefiles.html#Rule-Definition Signed-off-by: W. Trevor King <wking@tremily.us> Closes: #776 Approved by: rhatdan
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions