diff options
author | David Gibson <david@gibson.dropbear.id.au> | 2022-01-10 17:52:48 +1100 |
---|---|---|
committer | David Gibson <david@gibson.dropbear.id.au> | 2022-01-21 13:51:25 +1100 |
commit | 0b5136c7cefb52a18eec9e69c5d27d82b04ea867 (patch) | |
tree | 71ade53707a2b9ea274e66e74e3b42a904e9cb8b /LICENSE | |
parent | 9241b4e340386abfc5fcd32dab86fa5ef0002bac (diff) | |
download | podman-0b5136c7cefb52a18eec9e69c5d27d82b04ea867.tar.gz podman-0b5136c7cefb52a18eec9e69c5d27d82b04ea867.tar.bz2 podman-0b5136c7cefb52a18eec9e69c5d27d82b04ea867.zip |
Make error message matching in 030-run.bats less fragile
Amongst other things 030-run.bats checks for sensible error messages when
attempting a "podman run" with a non-existent or inaccessible path. It
checks for these messages, which come from the low-level runtime, in a lot
of detail, including separate versions for runc and crun. This is fragile
in several ways:
* It's likely to fail if using a runtime other than crun or runc
* It relies on detecting whether the runtime is crun vs. runc using the
path, which could fail if the binary has been named something unusual
* It will break if crun or runc ever alter their error message (even if
it's just changing case)
This replaces the checked versions with a much more accepting regex which
will work for both the runc and crun messages, while still looking for the
essential pieces. This isn't guaranteed to work with other runtimes, but
it's much more likely to.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'LICENSE')
0 files changed, 0 insertions, 0 deletions