summaryrefslogtreecommitdiff
path: root/Makefile
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2021-01-07 13:57:35 -0700
committerEd Santiago <santiago@redhat.com>2021-01-19 10:45:58 -0700
commit9f6bb3563d7a311a7e5628d18210c2c263af962d (patch)
tree9d208c129ff8ea39a0c2c0057b153896824ed949 /Makefile
parent8c6df5e93e6941a7f50da651678751f7dfec900e (diff)
downloadpodman-9f6bb3563d7a311a7e5628d18210c2c263af962d.tar.gz
podman-9f6bb3563d7a311a7e5628d18210c2c263af962d.tar.bz2
podman-9f6bb3563d7a311a7e5628d18210c2c263af962d.zip
CI: smoke test: insist on adding tests on PRs
On each PR (with a few exceptions), check the list of git-touched files, and abort if no tests are added. Include instructions on how to bypass the check if tests really aren't needed. Include a hardcoded exception list for PRs that only touch a well-known subset of "safe" files: docs, .cirrus.yml, vendor, version, hack, contrib, or *.md. This list is likely to need tuning over time. Add a test suite, but not one recognized by the new script (because it's a "*.t" file), so: [NO TESTS NEEDED] Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'Makefile')
-rw-r--r--Makefile6
1 files changed, 5 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index 864efa03e..1083d0a95 100644
--- a/Makefile
+++ b/Makefile
@@ -407,6 +407,10 @@ man-page-check:
swagger-check:
hack/swagger-check
+.PHONY: tests-included
+tests-included:
+ contrib/cirrus/pr-should-include-tests
+
.PHONY: codespell
codespell:
codespell -S bin,vendor,.git,go.sum,changelog.txt,.cirrus.yml,"RELEASE_NOTES.md,*.xz,*.gz,*.tar,*.tgz,bin2img,*ico,*.png,*.1,*.5,copyimg,*.orig,apidoc.go" -L uint,iff,od,seeked,splitted,marge,ERRO,hist -w
@@ -644,7 +648,7 @@ validate.completions:
if [ -x /bin/fish ]; then /bin/fish completions/fish/podman.fish; fi
.PHONY: validate
-validate: gofmt lint .gitvalidation validate.completions man-page-check swagger-check
+validate: gofmt lint .gitvalidation validate.completions man-page-check swagger-check tests-included
.PHONY: build-all-new-commits
build-all-new-commits: