diff options
| author | Matthew Heon <matthew.heon@pm.me> | 2020-02-10 15:29:36 -0500 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2020-02-10 16:32:02 -0500 |
| commit | d99f2ee78478853803c6ae25be52f2bd677e9cec (patch) | |
| tree | d89cee7ee2403988347ca6b294ea03e731371d74 /cmd/podman/commit.go | |
| parent | e57253d06841d7a128ef760f8c47acf4b59157df (diff) | |
| download | podman-d99f2ee78478853803c6ae25be52f2bd677e9cec.tar.gz podman-d99f2ee78478853803c6ae25be52f2bd677e9cec.tar.bz2 podman-d99f2ee78478853803c6ae25be52f2bd677e9cec.zip | |
Remove incorrect validation of --change for commit
The validation logic was failing on properly-formatted changes.
There's already validation in Commit itself, so no need to
duplicate.
Fixes #5148
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'cmd/podman/commit.go')
| -rw-r--r-- | cmd/podman/commit.go | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/cmd/podman/commit.go b/cmd/podman/commit.go index 604e8d31c..b4d249c66 100644 --- a/cmd/podman/commit.go +++ b/cmd/podman/commit.go @@ -6,7 +6,6 @@ import ( "github.com/containers/libpod/cmd/podman/cliconfig" "github.com/containers/libpod/pkg/adapter" - "github.com/containers/libpod/pkg/util" "github.com/pkg/errors" "github.com/spf13/cobra" ) @@ -65,17 +64,6 @@ func commitCmd(c *cliconfig.CommitValues) error { if len(args) > 1 { reference = args[1] } - if c.Flag("change").Changed { - for _, change := range c.Change { - splitChange := strings.Split(strings.ToUpper(change), "=") - if len(splitChange) == 1 { - splitChange = strings.Split(strings.ToUpper(change), " ") - } - if !util.StringInSlice(splitChange[0], ChangeCmds) { - return errors.Errorf("invalid syntax for --change: %s", change) - } - } - } iid, err := runtime.Commit(getContext(), c, container, reference) if err != nil { |