diff options
| author | Daniel J Walsh <dwalsh@redhat.com> | 2021-10-20 10:54:13 -0400 |
|---|---|---|
| committer | Daniel J Walsh <dwalsh@redhat.com> | 2021-10-21 13:29:44 -0400 |
| commit | 8e3760c29fb46f3be148adf87f9240994bdd1ba4 (patch) | |
| tree | 3d5317b3570d34ce8d8acadf1b107386e717dab0 /cmd/podman/common/create.go | |
| parent | 54f2c9a54034c01a542b2b1c79bbbceb7d12c260 (diff) | |
| download | podman-8e3760c29fb46f3be148adf87f9240994bdd1ba4.tar.gz podman-8e3760c29fb46f3be148adf87f9240994bdd1ba4.tar.bz2 podman-8e3760c29fb46f3be148adf87f9240994bdd1ba4.zip | |
Remove --kernel-memory options
Kernel memory option has been depracated in runtime-spec, It is
believed that it will not work properly on certain kernels. runc
ignores it.
This PR removes documentation of the flag and also prints a warning if
a user uses it.
[NO NEW TESTS NEEDED]
Helps Fix: https://github.com/containers/podman/issues/12045
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Diffstat (limited to 'cmd/podman/common/create.go')
| -rw-r--r-- | cmd/podman/common/create.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/cmd/podman/common/create.go b/cmd/podman/common/create.go index a3ff37c19..6270bad16 100644 --- a/cmd/podman/common/create.go +++ b/cmd/podman/common/create.go @@ -319,6 +319,9 @@ func DefineCreateFlags(cmd *cobra.Command, cf *entities.ContainerCreateOptions, "Kernel memory limit "+sizeWithUnitFormat, ) _ = cmd.RegisterFlagCompletionFunc(kernelMemoryFlagName, completion.AutocompleteNone) + // kernel-memory is deprecated in the runtime spec. + _ = createFlags.MarkHidden("kernel-memory") + logDriverFlagName := "log-driver" createFlags.StringVar( &cf.LogDriver, |