diff options
author | Matthew Heon <matthew.heon@pm.me> | 2020-07-09 13:50:01 -0400 |
---|---|---|
committer | Matthew Heon <matthew.heon@pm.me> | 2020-07-09 13:54:47 -0400 |
commit | 4b784b377cea542228278f2ea501baa32b885be7 (patch) | |
tree | 8f53bd81b834ea36a45de84a26de3a680a41188a /cmd/podman/common/create.go | |
parent | 059bd37511e917f860e784307ee1f2766d8d4ec3 (diff) | |
download | podman-4b784b377cea542228278f2ea501baa32b885be7.tar.gz podman-4b784b377cea542228278f2ea501baa32b885be7.tar.bz2 podman-4b784b377cea542228278f2ea501baa32b885be7.zip |
Remove all instances of named return "err" from Libpod
This was inspired by https://github.com/cri-o/cri-o/pull/3934 and
much of the logic for it is contained there. However, in brief,
a named return called "err" can cause lots of code confusion and
encourages using the wrong err variable in defer statements,
which can make them work incorrectly. Using a separate name which
is not used elsewhere makes it very clear what the defer should
be doing.
As part of this, remove a large number of named returns that were
not used anywhere. Most of them were once needed, but are no
longer necessary after previous refactors (but were accidentally
retained).
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'cmd/podman/common/create.go')
0 files changed, 0 insertions, 0 deletions