summaryrefslogtreecommitdiff
path: root/cmd/podman/common/netflags.go
diff options
context:
space:
mode:
authoraleks-mariusz <a+git-commit@alek.cx>2020-06-16 11:36:33 +0100
committerGiuseppe Scrivano <gscrivan@redhat.com>2020-07-15 08:04:35 +0200
commit8d12f19371eb9d91139f7b982cde2926ec8c8e74 (patch)
treed589e8dcc9b097f5e63aa2b3272c4e8e3ad35d44 /cmd/podman/common/netflags.go
parentc4843d4e9ce395f1bbcaae848e6172f5a4519a35 (diff)
downloadpodman-8d12f19371eb9d91139f7b982cde2926ec8c8e74.tar.gz
podman-8d12f19371eb9d91139f7b982cde2926ec8c8e74.tar.bz2
podman-8d12f19371eb9d91139f7b982cde2926ec8c8e74.zip
allow switching of port-forward approaches in rootless/using slirp4netns
As of podman 1.8.0, because of commit da7595a, the default approach of providing port-forwarding in rootless mode has switched (and been hard-coded) to rootlessport, for the purpose of providing super performance. The side-effect of this switch is source within the container to the port-forwarded service always appears to originate from 127.0.0.1 (see issue #5138). This commit allows a user to specify if they want to revert to the previous approach of leveraging slirp4netns add_hostfwd() api which, although not as stellar performance, restores usefulness of seeing incoming traffic origin IP addresses. The change should be transparent; when not specified, rootlessport will continue to be used, however if specifying --net slirp4netns:slirplisten the old approach will be used. Note: the above may imply the restored port-forwarding via slirp4netns is not as performant as the new rootlessport approach, however the figures shared in the original commit that introduced rootlessport are as follows: slirp4netns: 8.3 Gbps, RootlessKit: 27.3 Gbps, which are more than sufficient for many use cases where the origin of traffic is more important than limits that cannot be reached due to bottlenecks elsewhere. Signed-off-by: Aleks Mariusz <m.k@alek.cx> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Diffstat (limited to 'cmd/podman/common/netflags.go')
0 files changed, 0 insertions, 0 deletions