summaryrefslogtreecommitdiff
path: root/cmd/podman/common/util.go
diff options
context:
space:
mode:
authorMatthew Heon <matthew.heon@pm.me>2020-10-07 14:05:34 -0400
committerMatthew Heon <matthew.heon@pm.me>2020-10-08 09:16:10 -0400
commitb754ba975327904e040824e9ca64e7e39c3dde9d (patch)
tree5cdb3de74671f57652e6adb332713bb841cb2f99 /cmd/podman/common/util.go
parent173e3c2faa74e5ef1b941338c06e5dd7dca68ac2 (diff)
downloadpodman-b754ba975327904e040824e9ca64e7e39c3dde9d.tar.gz
podman-b754ba975327904e040824e9ca64e7e39c3dde9d.tar.bz2
podman-b754ba975327904e040824e9ca64e7e39c3dde9d.zip
Ports given only by number should have random host port
In Podman 1.9.3, `podman run -p 80` would assign port 80 in the container to a random port on the host. In Podman 2.0 and up, it assigned Port 80 in the container to Port 80 on the host. This is an easy fix, fortunately - just need to remove the bit that assumed host port, if not given, should be set to container port. We also had a test for the bad behavior, so fix it to test for the correct way of doing things. Fixes #7947 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'cmd/podman/common/util.go')
-rw-r--r--cmd/podman/common/util.go2
1 files changed, 0 insertions, 2 deletions
diff --git a/cmd/podman/common/util.go b/cmd/podman/common/util.go
index 17e779c86..a971aa957 100644
--- a/cmd/podman/common/util.go
+++ b/cmd/podman/common/util.go
@@ -200,8 +200,6 @@ func parseSplitPort(hostIP, hostPort *string, ctrPort string, protocol *string)
}
newPort.HostPort = hostStart
}
- } else {
- newPort.HostPort = newPort.ContainerPort
}
hport := newPort.HostPort