summaryrefslogtreecommitdiff
path: root/cmd/podman/common
diff options
context:
space:
mode:
authorOpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>2021-06-01 19:41:46 +0200
committerGitHub <noreply@github.com>2021-06-01 19:41:46 +0200
commitcbffdddce6d741eac4f3efa132016aba99683500 (patch)
tree927b74764e93a47aae61597100502acbe17f1afd /cmd/podman/common
parent7a52440a6d7fe7ac1ddccf9fe7247d7abca8ecce (diff)
parent7ef3981abe2412727840a2886489a08c03a05299 (diff)
downloadpodman-cbffdddce6d741eac4f3efa132016aba99683500.tar.gz
podman-cbffdddce6d741eac4f3efa132016aba99683500.tar.bz2
podman-cbffdddce6d741eac4f3efa132016aba99683500.zip
Merge pull request #10488 from baude/machinehostnetwork
Enable port forwarding on host
Diffstat (limited to 'cmd/podman/common')
-rw-r--r--cmd/podman/common/netflags.go9
1 files changed, 7 insertions, 2 deletions
diff --git a/cmd/podman/common/netflags.go b/cmd/podman/common/netflags.go
index 9941bc716..4f634f355 100644
--- a/cmd/podman/common/netflags.go
+++ b/cmd/podman/common/netflags.go
@@ -85,7 +85,10 @@ func DefineNetFlags(cmd *cobra.Command) {
)
}
-func NetFlagsToNetOptions(cmd *cobra.Command) (*entities.NetOptions, error) {
+// NetFlagsToNetOptions parses the network flags for the given cmd.
+// The netnsFromConfig bool is used to indicate if the --network flag
+// should always be parsed regardless if it was set on the cli.
+func NetFlagsToNetOptions(cmd *cobra.Command, netnsFromConfig bool) (*entities.NetOptions, error) {
var (
err error
)
@@ -193,7 +196,9 @@ func NetFlagsToNetOptions(cmd *cobra.Command) (*entities.NetOptions, error) {
return nil, err
}
- if cmd.Flags().Changed("network") {
+ // parse the --network value only when the flag is set or we need to use
+ // the netns config value, e.g. when --pod is not used
+ if netnsFromConfig || cmd.Flag("network").Changed {
network, err := cmd.Flags().GetString("network")
if err != nil {
return nil, err