diff options
author | baude <bbaude@redhat.com> | 2019-02-21 10:09:34 -0600 |
---|---|---|
committer | baude <bbaude@redhat.com> | 2019-02-22 14:12:36 -0600 |
commit | 6208d534645648ccee0e136b0e659cee1c26ab78 (patch) | |
tree | 0caf686d78ba511ed4342df653a9a390dbff8379 /cmd/podman/errors.go | |
parent | 8039ccf4d560acbc308066cf8996bc4e6167a4a9 (diff) | |
download | podman-6208d534645648ccee0e136b0e659cee1c26ab78.tar.gz podman-6208d534645648ccee0e136b0e659cee1c26ab78.tar.bz2 podman-6208d534645648ccee0e136b0e659cee1c26ab78.zip |
make remote-client error messaging more robust
the remote-client is currently weak for carrying error messages
over the varlink interface and displaying something useful to users
and developers for the purposes of debug. this is a starting point
to improve that user experience.
Signed-off-by: baude <bbaude@redhat.com>
Diffstat (limited to 'cmd/podman/errors.go')
-rw-r--r-- | cmd/podman/errors.go | 41 |
1 files changed, 41 insertions, 0 deletions
diff --git a/cmd/podman/errors.go b/cmd/podman/errors.go new file mode 100644 index 000000000..192f97049 --- /dev/null +++ b/cmd/podman/errors.go @@ -0,0 +1,41 @@ +package main + +import ( + "fmt" + "os" + "os/exec" + "syscall" + + "github.com/containers/libpod/cmd/podman/varlink" + "github.com/pkg/errors" + "github.com/sirupsen/logrus" +) + +func outputError(err error) { + if MainGlobalOpts.LogLevel == "debug" { + logrus.Errorf(err.Error()) + } else { + if ee, ok := err.(*exec.ExitError); ok { + if status, ok := ee.Sys().(syscall.WaitStatus); ok { + exitCode = status.ExitStatus() + } + } + var ne error + switch e := err.(type) { + // For some reason golang wont let me list them with commas so listing them all. + case *iopodman.ImageNotFound: + ne = errors.New(e.Reason) + case *iopodman.ContainerNotFound: + ne = errors.New(e.Reason) + case *iopodman.PodNotFound: + ne = errors.New(e.Reason) + case *iopodman.VolumeNotFound: + ne = errors.New(e.Reason) + case *iopodman.ErrorOccurred: + ne = errors.New(e.Reason) + default: + ne = err + } + fmt.Fprintln(os.Stderr, "Error:", ne.Error()) + } +} |