diff options
author | Chris Evich <cevich@redhat.com> | 2019-09-26 10:35:16 -0400 |
---|---|---|
committer | Chris Evich <cevich@redhat.com> | 2019-09-26 10:56:24 -0400 |
commit | 437d9d2cdeae7ffa01dbe06f96d155f1da36a689 (patch) | |
tree | 75caab41fa20b42c6ec73403f91a258dd28ac2a6 /cmd/podman/generate_systemd.go | |
parent | d76b21e27a7cef26865a05be02632ca76f9cf2ea (diff) | |
download | podman-437d9d2cdeae7ffa01dbe06f96d155f1da36a689.tar.gz podman-437d9d2cdeae7ffa01dbe06f96d155f1da36a689.tar.bz2 podman-437d9d2cdeae7ffa01dbe06f96d155f1da36a689.zip |
Move noCache logic lower in stack
One or more tests are not taking advantage of the local image cache.
This has been observed to cause a testing flake in at least one
`--sigproxy` test which uses `PodmanTestIntegration.PodmanPID()`.
It has a rather short timeout of 15-seconds, which isn't always
enough time to pull down a remote image.
Fix this by reloacing the `noCache` logic from
`PodmanTest.PodmanAsUserBase()` down the stack into
`PodmanTestIntegration.makeOptions()`. This also eliminates the need to
also check if a remote-client is being used - since it uses a different
function.
Also reverse the parameter order in `PodmanTest.PodmanBase` so that
everywhere is consistently `noEvents` then `noCache`.
Signed-off-by: Chris Evich <cevich@redhat.com>
Diffstat (limited to 'cmd/podman/generate_systemd.go')
0 files changed, 0 insertions, 0 deletions