diff options
| author | Daniel J Walsh <dwalsh@redhat.com> | 2020-10-20 16:17:25 -0400 |
|---|---|---|
| committer | Daniel J Walsh <dwalsh@redhat.com> | 2020-10-21 05:33:00 -0400 |
| commit | d72918fe6f19a080892df5f3e87d96d35b7720f4 (patch) | |
| tree | 75218d53b9bb8f1fd30209ef0bbe5a47acd6fb08 /cmd/podman/images/build.go | |
| parent | 94873a237ab52db27916b8954e489fe780eea069 (diff) | |
| download | podman-d72918fe6f19a080892df5f3e87d96d35b7720f4.tar.gz podman-d72918fe6f19a080892df5f3e87d96d35b7720f4.tar.bz2 podman-d72918fe6f19a080892df5f3e87d96d35b7720f4.zip | |
Podman build should default to not usins stdin
Currently we leak stdin into podman builds, which can lead
to issues like run commands inside of the container waiting for
user input.
We should not take input from users other then if the user specifies
podman build -f - or podman build -, which are taken care of in other code.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Diffstat (limited to 'cmd/podman/images/build.go')
| -rw-r--r-- | cmd/podman/images/build.go | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/cmd/podman/images/build.go b/cmd/podman/images/build.go index ac1b2c848..aa4e87952 100644 --- a/cmd/podman/images/build.go +++ b/cmd/podman/images/build.go @@ -282,8 +282,7 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil flags.Layers = false } - var stdin, stdout, stderr, reporter *os.File - stdin = os.Stdin + var stdout, stderr, reporter *os.File stdout = os.Stdout stderr = os.Stderr reporter = os.Stderr @@ -422,7 +421,6 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil ForceRmIntermediateCtrs: flags.ForceRm, IDMappingOptions: idmappingOptions, IIDFile: flags.Iidfile, - In: stdin, Isolation: isolation, Labels: flags.Label, Layers: flags.Layers, |