diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2021-01-27 16:49:47 +0100 |
|---|---|---|
| committer | Valentin Rothberg <rothberg@redhat.com> | 2021-01-27 16:49:47 +0100 |
| commit | 15caebfe561952eaadd4896b7efb56f26724cce5 (patch) | |
| tree | a0f9abfb073e3628bee609f32a93fcc1f6630f09 /cmd/podman/images/build.go | |
| parent | 2ff4da9b59df27584e436ff59a9d12b2c5e5e410 (diff) | |
| download | podman-15caebfe561952eaadd4896b7efb56f26724cce5.tar.gz podman-15caebfe561952eaadd4896b7efb56f26724cce5.tar.bz2 podman-15caebfe561952eaadd4896b7efb56f26724cce5.zip | |
podman build --pull: use correct policy
The `--pull` flag should be using the "pull if newer" pull policy rather
than "pull always". This aligns with what the help message states, what
Buildah does and, according to #9111, what was done before,
Also add a test to prevent future regressions.
Fixes: #9111
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'cmd/podman/images/build.go')
| -rw-r--r-- | cmd/podman/images/build.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cmd/podman/images/build.go b/cmd/podman/images/build.go index 4219e325b..957c0ac2d 100644 --- a/cmd/podman/images/build.go +++ b/cmd/podman/images/build.go @@ -266,7 +266,7 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil pullPolicy := imagebuildah.PullIfMissing if c.Flags().Changed("pull") && flags.Pull { - pullPolicy = imagebuildah.PullAlways + pullPolicy = imagebuildah.PullIfNewer } if flags.PullAlways { pullPolicy = imagebuildah.PullAlways |