Merge pull request #6442 from Luap99/podman-autocomplete

Shell completion

1 files changed, 19 insertions, 8 deletions

diff --git a/cmd/podman/images/sign.go b/cmd/podman/images/sign.go
index f6c1f9856..529fb3d92 100644
--- a/cmd/podman/images/sign.go
+++ b/cmd/podman/images/sign.go
@@ -3,6 +3,8 @@ package images
 import (
 	"os"
 
+	"github.com/containers/common/pkg/completion"
+	"github.com/containers/podman/v2/cmd/podman/common"
 	"github.com/containers/podman/v2/cmd/podman/registry"
 	"github.com/containers/podman/v2/pkg/domain/entities"
 	"github.com/pkg/errors"
@@ -12,11 +14,12 @@ import (
 var (
 	signDescription = "Create a signature file that can be used later to verify the image."
 	signCommand     = &cobra.Command{
-		Use:   "sign [options] IMAGE [IMAGE...]",
-		Short: "Sign an image",
-		Long:  signDescription,
-		RunE:  sign,
-		Args:  cobra.MinimumNArgs(1),
+		Use:               "sign [options] IMAGE [IMAGE...]",
+		Short:             "Sign an image",
+		Long:              signDescription,
+		RunE:              sign,
+		Args:              cobra.MinimumNArgs(1),
+		ValidArgsFunction: common.AutocompleteImages,
 		Example: `podman image sign --sign-by mykey imageID
   podman image sign --sign-by mykey --directory ./mykeydir imageID`,
 	}
@@ -33,9 +36,17 @@ func init() {
 		Parent:  imageCmd,
 	})
 	flags := signCommand.Flags()
-	flags.StringVarP(&signOptions.Directory, "directory", "d", "", "Define an alternate directory to store signatures")
-	flags.StringVar(&signOptions.SignBy, "sign-by", "", "Name of the signing key")
-	flags.StringVar(&signOptions.CertDir, "cert-dir", "", "`Pathname` of a directory containing TLS certificates and keys")
+	directoryFlagName := "directory"
+	flags.StringVarP(&signOptions.Directory, directoryFlagName, "d", "", "Define an alternate directory to store signatures")
+	_ = signCommand.RegisterFlagCompletionFunc(directoryFlagName, completion.AutocompleteDefault)
+
+	signByFlagName := "sign-by"
+	flags.StringVar(&signOptions.SignBy, signByFlagName, "", "Name of the signing key")
+	_ = signCommand.RegisterFlagCompletionFunc(signByFlagName, completion.AutocompleteNone)
+
+	certDirFlagName := "cert-dir"
+	flags.StringVar(&signOptions.CertDir, certDirFlagName, "", "`Pathname` of a directory containing TLS certificates and keys")
+	_ = signCommand.RegisterFlagCompletionFunc(certDirFlagName, completion.AutocompleteDefault)
 }
 
 func sign(cmd *cobra.Command, args []string) error {