diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2019-10-04 16:00:11 +0200 |
|---|---|---|
| committer | Valentin Rothberg <rothberg@redhat.com> | 2019-10-15 12:16:47 +0200 |
| commit | 019f19cf4fbc0e17cb46bb6c992147cd9eebb287 (patch) | |
| tree | 38f3e85e824562233858389c75e0f09c80ce73db /cmd/podman/inspect.go | |
| parent | 25572cefa8f16580c4a61af86cf2c41281e0300f (diff) | |
| download | podman-019f19cf4fbc0e17cb46bb6c992147cd9eebb287.tar.gz podman-019f19cf4fbc0e17cb46bb6c992147cd9eebb287.tar.bz2 podman-019f19cf4fbc0e17cb46bb6c992147cd9eebb287.zip | |
inspect: rename ImageID go field to Image
The json field is called `Image` while the go field is called `ImageID`,
tricking users into filtering for `Image` which ultimately results in an
error. Hence, rename the field to `Image` to align json and go.
To prevent podman users from regressing, rename `Image` to `ImageID` in
the specified filters. Add tests to prevent us from regressing. Note
that consumers of the go API that are using `ImageID` are regressing;
ultimately we consider it to be a bug fix.
Fixes: #4193
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'cmd/podman/inspect.go')
| -rw-r--r-- | cmd/podman/inspect.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/cmd/podman/inspect.go b/cmd/podman/inspect.go index cff221cb0..872b59561 100644 --- a/cmd/podman/inspect.go +++ b/cmd/podman/inspect.go @@ -104,6 +104,9 @@ func inspectCmd(c *cliconfig.InspectValues) error { if strings.Contains(outputFormat, ".Dst") { outputFormat = strings.Replace(outputFormat, ".Dst", ".Destination", -1) } + if strings.Contains(outputFormat, ".ImageID") { + outputFormat = strings.Replace(outputFormat, ".ImageID", ".Image", -1) + } if latestContainer { lc, err := runtime.GetLatestContainer() if err != nil { |