diff options
| author | baude <bbaude@redhat.com> | 2019-02-21 10:09:34 -0600 |
|---|---|---|
| committer | baude <bbaude@redhat.com> | 2019-02-22 14:12:36 -0600 |
| commit | 6208d534645648ccee0e136b0e659cee1c26ab78 (patch) | |
| tree | 0caf686d78ba511ed4342df653a9a390dbff8379 /cmd/podman/main.go | |
| parent | 8039ccf4d560acbc308066cf8996bc4e6167a4a9 (diff) | |
| download | podman-6208d534645648ccee0e136b0e659cee1c26ab78.tar.gz podman-6208d534645648ccee0e136b0e659cee1c26ab78.tar.bz2 podman-6208d534645648ccee0e136b0e659cee1c26ab78.zip | |
make remote-client error messaging more robust
the remote-client is currently weak for carrying error messages
over the varlink interface and displaying something useful to users
and developers for the purposes of debug. this is a starting point
to improve that user experience.
Signed-off-by: baude <bbaude@redhat.com>
Diffstat (limited to 'cmd/podman/main.go')
| -rw-r--r-- | cmd/podman/main.go | 15 |
1 files changed, 2 insertions, 13 deletions
diff --git a/cmd/podman/main.go b/cmd/podman/main.go index 990e55a8c..cf6e44fcd 100644 --- a/cmd/podman/main.go +++ b/cmd/podman/main.go @@ -2,11 +2,9 @@ package main import ( "context" - "fmt" "io" "log/syslog" "os" - "os/exec" "runtime/pprof" "strings" "syscall" @@ -18,7 +16,7 @@ import ( "github.com/containers/libpod/pkg/tracing" "github.com/containers/libpod/version" "github.com/containers/storage/pkg/reexec" - opentracing "github.com/opentracing/opentracing-go" + "github.com/opentracing/opentracing-go" "github.com/pkg/errors" "github.com/sirupsen/logrus" lsyslog "github.com/sirupsen/logrus/hooks/syslog" @@ -223,16 +221,7 @@ func main() { return } if err := rootCmd.Execute(); err != nil { - if MainGlobalOpts.LogLevel == "debug" { - logrus.Errorf(err.Error()) - } else { - if ee, ok := err.(*exec.ExitError); ok { - if status, ok := ee.Sys().(syscall.WaitStatus); ok { - exitCode = status.ExitStatus() - } - } - fmt.Fprintln(os.Stderr, "Error:", err.Error()) - } + outputError(err) } else { // The exitCode modified from 125, indicates an application // running inside of a container failed, as opposed to the |