diff options
| author | Ed Santiago <santiago@redhat.com> | 2019-02-26 12:28:35 -0700 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2019-02-27 14:20:29 -0700 |
| commit | 9934507d74c97bccb753b04873eb74652600b6ff (patch) | |
| tree | e4519b72b661fd87759f7544bef1dd4a87852c3b /cmd/podman/pod_create.go | |
| parent | 4e553cfd468c06ae45a88c51c57137dc4607ffe4 (diff) | |
| download | podman-9934507d74c97bccb753b04873eb74652600b6ff.tar.gz podman-9934507d74c97bccb753b04873eb74652600b6ff.tar.bz2 podman-9934507d74c97bccb753b04873eb74652600b6ff.zip | |
Command-line input validation: reject unused args
Several podman commands accept no subcommands. Some
of those were not actually checking, though, which
could lead to user confusion. Added validation where
missing; and, refactored to minimize duplication.
(Side note: I decided against using cobra.NoArgs
because its error message, "unknown command",
misleadingly implies that there are known ones).
Also added validation to varlink
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'cmd/podman/pod_create.go')
| -rw-r--r-- | cmd/podman/pod_create.go | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/cmd/podman/pod_create.go b/cmd/podman/pod_create.go index f1bbecb84..43c211b2c 100644 --- a/cmd/podman/pod_create.go +++ b/cmd/podman/pod_create.go @@ -24,6 +24,7 @@ var ( _podCreateCommand = &cobra.Command{ Use: "create", + Args: noSubArgs, Short: "Create a new empty pod", Long: podCreateDescription, RunE: func(cmd *cobra.Command, args []string) error { @@ -59,9 +60,6 @@ func podCreateCmd(c *cliconfig.PodCreateValues) error { podIdFile *os.File ) - if len(c.InputArgs) > 0 { - return errors.New("podman pod create does not accept any arguments") - } runtime, err := adapter.GetRuntime(&c.PodmanCommand) if err != nil { return errors.Wrapf(err, "error creating libpod runtime") |