diff options
| author | Ed Santiago <santiago@redhat.com> | 2019-02-26 12:28:35 -0700 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2019-02-27 14:20:29 -0700 |
| commit | 9934507d74c97bccb753b04873eb74652600b6ff (patch) | |
| tree | e4519b72b661fd87759f7544bef1dd4a87852c3b /cmd/podman/pod_ps.go | |
| parent | 4e553cfd468c06ae45a88c51c57137dc4607ffe4 (diff) | |
| download | podman-9934507d74c97bccb753b04873eb74652600b6ff.tar.gz podman-9934507d74c97bccb753b04873eb74652600b6ff.tar.bz2 podman-9934507d74c97bccb753b04873eb74652600b6ff.zip | |
Command-line input validation: reject unused args
Several podman commands accept no subcommands. Some
of those were not actually checking, though, which
could lead to user confusion. Added validation where
missing; and, refactored to minimize duplication.
(Side note: I decided against using cobra.NoArgs
because its error message, "unknown command",
misleadingly implies that there are known ones).
Also added validation to varlink
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'cmd/podman/pod_ps.go')
| -rw-r--r-- | cmd/podman/pod_ps.go | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/cmd/podman/pod_ps.go b/cmd/podman/pod_ps.go index 70e077651..8e48740e6 100644 --- a/cmd/podman/pod_ps.go +++ b/cmd/podman/pod_ps.go @@ -121,6 +121,7 @@ var ( _podPsCommand = &cobra.Command{ Use: "ps", Aliases: []string{"ls", "list"}, + Args: noSubArgs, Short: "List pods", Long: podPsDescription, RunE: func(cmd *cobra.Command, args []string) error { @@ -160,10 +161,6 @@ func podPsCmd(c *cliconfig.PodPsValues) error { } defer runtime.Shutdown(false) - if len(c.InputArgs) > 0 { - return errors.Errorf("too many arguments, ps takes no arguments") - } - opts := podPsOptions{ NoTrunc: c.NoTrunc, Quiet: c.Quiet, |