Merge pull request #2413 from baude/remotepodstop

Enable more podman-remote pod commands

1 files changed, 15 insertions, 27 deletions

diff --git a/cmd/podman/pod_start.go b/cmd/podman/pod_start.go
index 3bba5c2e9..5761afd52 100644
--- a/cmd/podman/pod_start.go
+++ b/cmd/podman/pod_start.go
@@ -4,7 +4,7 @@ import (
 	"fmt"
 
 	"github.com/containers/libpod/cmd/podman/cliconfig"
-	"github.com/containers/libpod/cmd/podman/libpodruntime"
+	"github.com/containers/libpod/pkg/adapter"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
@@ -45,38 +45,26 @@ func init() {
 }
 
 func podStartCmd(c *cliconfig.PodStartValues) error {
-	runtime, err := libpodruntime.GetRuntime(&c.PodmanCommand)
+	runtime, err := adapter.GetRuntime(&c.PodmanCommand)
 	if err != nil {
 		return errors.Wrapf(err, "could not get runtime")
 	}
 	defer runtime.Shutdown(false)
 
-	// getPodsFromContext returns an error when a requested pod
-	// isn't found. The only fatal error scenerio is when there are no pods
-	// in which case the following loop will be skipped.
-	pods, lastError := getPodsFromContext(&c.PodmanCommand, runtime)
-
-	ctx := getContext()
-	for _, pod := range pods {
-		ctr_errs, err := pod.Start(ctx)
-		if ctr_errs != nil {
-			for ctr, err := range ctr_errs {
-				if lastError != nil {
-					logrus.Errorf("%q", lastError)
-				}
-				lastError = errors.Wrapf(err, "unable to start container %q on pod %q", ctr, pod.ID())
-			}
-			continue
-		}
-		if err != nil {
-			if lastError != nil {
-				logrus.Errorf("%q", lastError)
-			}
-			lastError = errors.Wrapf(err, "unable to start pod %q", pod.ID())
-			continue
-		}
-		fmt.Println(pod.ID())
+	podStartIDs, podStartErrors := runtime.StartPods(getContext(), c)
+	for _, p := range podStartIDs {
+		fmt.Println(p)
+	}
+	if len(podStartErrors) == 0 {
+		return nil
 	}
+	// Grab the last error
+	lastError := podStartErrors[len(podStartErrors)-1]
+	// Remove the last error from the error slice
+	podStartErrors = podStartErrors[:len(podStartErrors)-1]
 
+	for _, err := range podStartErrors {
+		logrus.Errorf("%q", err)
+	}
 	return lastError
 }