diff options
author | baude <bbaude@redhat.com> | 2019-04-15 09:53:38 -0500 |
---|---|---|
committer | baude <bbaude@redhat.com> | 2019-04-15 12:21:51 -0500 |
commit | 6fb0a706af438778dd372d4b05b417fb30a45965 (patch) | |
tree | d1ba6e427d8524630ceb1c82eaec92c91b061e6f /cmd/podman/pull.go | |
parent | 6e1dab76e2282774d384ec3bc46e314e9b030595 (diff) | |
download | podman-6fb0a706af438778dd372d4b05b417fb30a45965.tar.gz podman-6fb0a706af438778dd372d4b05b417fb30a45965.tar.bz2 podman-6fb0a706af438778dd372d4b05b417fb30a45965.zip |
Fix segfaults attribute to missing options
In cases where the remote client culls options to a command, we need to
be sure that the lookup for that flag does not result in a nil pointer.
To do so, we add a Remote attribute to the podman struct and then cli
helper funcs are now aware they are remote.
Signed-off-by: baude <bbaude@redhat.com>
Diffstat (limited to 'cmd/podman/pull.go')
-rw-r--r-- | cmd/podman/pull.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/cmd/podman/pull.go b/cmd/podman/pull.go index 7cc7b65b3..04eb5bd46 100644 --- a/cmd/podman/pull.go +++ b/cmd/podman/pull.go @@ -32,6 +32,7 @@ var ( RunE: func(cmd *cobra.Command, args []string) error { pullCommand.InputArgs = args pullCommand.GlobalFlags = MainGlobalOpts + pullCommand.Remote = remoteclient return pullCmd(&pullCommand) }, Example: `podman pull imageName @@ -117,7 +118,7 @@ func pullCmd(c *cliconfig.PullValues) (retError error) { DockerRegistryCreds: registryCreds, DockerCertPath: c.CertDir, } - if c.Flag("tls-verify").Changed { + if c.IsSet("tls-verify") { dockerRegistryOptions.DockerInsecureSkipTLSVerify = types.NewOptionalBool(!c.TlsVerify) } |